| Message ID | 20230331082709.35955-1-mhartmay@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [kvm-unit-tests,v4] s390x/Makefile: refactor CPPFLAGS | expand |
Quoting Marc Hartmayer (2023-03-31 10:27:09) > This change makes it easier to reuse them. While at it, add a comment > why the `lib` include path is required. > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> > --- > s390x/Makefile | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/s390x/Makefile b/s390x/Makefile > index 71e6563bbb61..06720aace828 100644 > --- a/s390x/Makefile > +++ b/s390x/Makefile > @@ -63,9 +63,14 @@ test_cases: $(tests) > test_cases_binary: $(tests_binary) > test_cases_pv: $(tests_pv_binary) > > +INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x > +# Include generated header files (e.g. in case of out-of-source builds) > +INCLUDE_PATHS += lib Do you mind if I fix this up during picking? ERROR: trailing whitespace #35: FILE: s390x/Makefile:68: +INCLUDE_PATHS += lib $
Quoting Marc Hartmayer (2023-03-31 10:27:09) > This change makes it easier to reuse them. While at it, add a comment > why the `lib` include path is required. > > Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> Reviewed-by: Nico Boehr <nrb@linux.ibm.com> Tested-by: Nico Boehr <nrb@linux.ibm.com>
Nico Boehr <nrb@linux.ibm.com> writes: > Quoting Marc Hartmayer (2023-03-31 10:27:09) >> This change makes it easier to reuse them. While at it, add a comment >> why the `lib` include path is required. >> >> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> >> --- >> s390x/Makefile | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/s390x/Makefile b/s390x/Makefile >> index 71e6563bbb61..06720aace828 100644 >> --- a/s390x/Makefile >> +++ b/s390x/Makefile >> @@ -63,9 +63,14 @@ test_cases: $(tests) >> test_cases_binary: $(tests_binary) >> test_cases_pv: $(tests_pv_binary) >> >> +INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x >> +# Include generated header files (e.g. in case of out-of-source builds) >> +INCLUDE_PATHS += lib > > Do you mind if I fix this up during picking? Please fix it, thanks. > > ERROR: trailing whitespace > #35: FILE: s390x/Makefile:68: > +INCLUDE_PATHS += lib $ -- Kind regards / Beste Grüße Marc Hartmayer IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Gregor Pillen Geschäftsführung: David Faller Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
diff --git a/s390x/Makefile b/s390x/Makefile index 71e6563bbb61..06720aace828 100644 --- a/s390x/Makefile +++ b/s390x/Makefile @@ -63,9 +63,14 @@ test_cases: $(tests) test_cases_binary: $(tests_binary) test_cases_pv: $(tests_pv_binary) +INCLUDE_PATHS = $(SRCDIR)/lib $(SRCDIR)/lib/s390x +# Include generated header files (e.g. in case of out-of-source builds) +INCLUDE_PATHS += lib +CPPFLAGS = $(addprefix -I,$(INCLUDE_PATHS)) + CFLAGS += -std=gnu99 CFLAGS += -ffreestanding -CFLAGS += -I $(SRCDIR)/lib -I $(SRCDIR)/lib/s390x -I lib +CFLAGS += $(CPPFLAGS) CFLAGS += -O2 CFLAGS += -march=zEC12 CFLAGS += -mbackchain
This change makes it easier to reuse them. While at it, add a comment why the `lib` include path is required. Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com> --- s390x/Makefile | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)