| Message ID | 20230504131654.24922-1-oleksandr@natalenko.name (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio/pci: demote hiding ecap messages to debug level | expand |
On 5/4/23 15:16, Oleksandr Natalenko wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> Acked-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */
On Thu, 4 May 2023 15:16:54 +0200 Oleksandr Natalenko <oleksandr@natalenko.name> wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */ Looks fine to me, though I might adjust that next line to keep the previous alignment. In general this has certainly caused more confusion than insightful information, so demoting it to debug is a good idea. Thanks, Alex
Hello. On pátek 5. května 2023 1:01:11 CEST Alex Williamson wrote: > On Thu, 4 May 2023 15:16:54 +0200 > Oleksandr Natalenko <oleksandr@natalenko.name> wrote: > > > Seeing a burst of messages like this: > > > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > > > is of little to no value for an ordinary user. > > > > Hence, use pci_dbg() instead of pci_info(). > > > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > > --- > > drivers/vfio/pci/vfio_pci_config.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > > index 948cdd464f4e..dd8dda14e701 100644 > > --- a/drivers/vfio/pci/vfio_pci_config.c > > +++ b/drivers/vfio/pci/vfio_pci_config.c > > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > > } > > > > if (!len) { > > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > > __func__, ecap, epos); > > > > /* If not the first in the chain, we can skip over it */ > > Looks fine to me, though I might adjust that next line to keep the > previous alignment. Sure, but if you want me to send v2 with this, please let me know. Thanks. > In general this has certainly caused more > confusion than insightful information, so demoting it to debug is a > good idea. Thanks, > > Alex > >
Tested-by: YangHang Liu <yanghliu@redhat.com> On 5/4/2023 9:16 PM, Oleksandr Natalenko wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */
On Thu, 4 May 2023 15:16:54 +0200 Oleksandr Natalenko <oleksandr@natalenko.name> wrote: > Seeing a burst of messages like this: > > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 > vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 > vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 > > is of little to no value for an ordinary user. > > Hence, use pci_dbg() instead of pci_info(). > > Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> > --- > drivers/vfio/pci/vfio_pci_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c > index 948cdd464f4e..dd8dda14e701 100644 > --- a/drivers/vfio/pci/vfio_pci_config.c > +++ b/drivers/vfio/pci/vfio_pci_config.c > @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) > } > > if (!len) { > - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", > + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", > __func__, ecap, epos); > > /* If not the first in the chain, we can skip over it */ Applied to vfio next branch for v6.5. Thanks! Alex
diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index 948cdd464f4e..dd8dda14e701 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -1643,7 +1643,7 @@ static int vfio_ecap_init(struct vfio_pci_core_device *vdev) } if (!len) { - pci_info(pdev, "%s: hiding ecap %#x@%#x\n", + pci_dbg(pdev, "%s: hiding ecap %#x@%#x\n", __func__, ecap, epos); /* If not the first in the chain, we can skip over it */
Seeing a burst of messages like this: vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 vfio-pci 0000:98:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 vfio-pci 0000:98:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x19@0x1d0 vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x25@0x200 vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x26@0x210 vfio-pci 0000:b1:00.0: vfio_ecap_init: hiding ecap 0x27@0x250 vfio-pci 0000:b1:00.1: vfio_ecap_init: hiding ecap 0x25@0x200 is of little to no value for an ordinary user. Hence, use pci_dbg() instead of pci_info(). Signed-off-by: Oleksandr Natalenko <oleksandr@natalenko.name> --- drivers/vfio/pci/vfio_pci_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)