| Message ID | 20230518091339.1102-2-binbin.wu@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: Fix some comments | expand |
On 6/6/2023 10:23 PM, Xu Yilun wrote: > On 2023-05-18 at 17:13:37 +0800, Binbin Wu wrote: >> Fix comment for vcpu ioctl version of KVM_ENABLE_CAP. >> >> KVM provides ioctl KVM_ENABLE_CAP to allow userspace to enable an >> extension which is not enabled by default. For vcpu ioctl version, >> it is available with the capability KVM_CAP_ENABLE_CAP. For vm ioctl >> version, it is available with the capability KVM_CAP_ENABLE_CAP_VM. >> >> Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com> >> --- >> include/uapi/linux/kvm.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >> index 737318b1c1d9..bddf2871db8f 100644 >> --- a/include/uapi/linux/kvm.h >> +++ b/include/uapi/linux/kvm.h > tools/include/uapi/linux/kvm.h also needs the change? Sean suggested "never update KVM's uapi headers in tools/ in KVM's tree" So I dropped the change to tools/include/uapi/linux/kvm.h You can refer to the following links for detials: https://lore.kernel.org/kvm/ZGVGkpvWQqLX2BrV@google.com/ https://lore.kernel.org/all/Y8bZ%2FJ98V5i3wG%2Fv@google.com/ > > Thanks, > Yilun > >> @@ -1613,7 +1613,7 @@ struct kvm_s390_ucas_mapping { >> #define KVM_GET_DEBUGREGS _IOR(KVMIO, 0xa1, struct kvm_debugregs) >> #define KVM_SET_DEBUGREGS _IOW(KVMIO, 0xa2, struct kvm_debugregs) >> /* >> - * vcpu version available with KVM_ENABLE_CAP >> + * vcpu version available with KVM_CAP_ENABLE_CAP >> * vm version available with KVM_CAP_ENABLE_CAP_VM >> */ >> #define KVM_ENABLE_CAP _IOW(KVMIO, 0xa3, struct kvm_enable_cap) >> -- >> 2.25.1 >>
On 2023-05-18 at 17:13:37 +0800, Binbin Wu wrote: > Fix comment for vcpu ioctl version of KVM_ENABLE_CAP. > > KVM provides ioctl KVM_ENABLE_CAP to allow userspace to enable an > extension which is not enabled by default. For vcpu ioctl version, > it is available with the capability KVM_CAP_ENABLE_CAP. For vm ioctl > version, it is available with the capability KVM_CAP_ENABLE_CAP_VM. > > Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com> > --- > include/uapi/linux/kvm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 737318b1c1d9..bddf2871db8f 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h tools/include/uapi/linux/kvm.h also needs the change? Thanks, Yilun > @@ -1613,7 +1613,7 @@ struct kvm_s390_ucas_mapping { > #define KVM_GET_DEBUGREGS _IOR(KVMIO, 0xa1, struct kvm_debugregs) > #define KVM_SET_DEBUGREGS _IOW(KVMIO, 0xa2, struct kvm_debugregs) > /* > - * vcpu version available with KVM_ENABLE_CAP > + * vcpu version available with KVM_CAP_ENABLE_CAP > * vm version available with KVM_CAP_ENABLE_CAP_VM > */ > #define KVM_ENABLE_CAP _IOW(KVMIO, 0xa3, struct kvm_enable_cap) > -- > 2.25.1 >
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h index 737318b1c1d9..bddf2871db8f 100644 --- a/include/uapi/linux/kvm.h +++ b/include/uapi/linux/kvm.h @@ -1613,7 +1613,7 @@ struct kvm_s390_ucas_mapping { #define KVM_GET_DEBUGREGS _IOR(KVMIO, 0xa1, struct kvm_debugregs) #define KVM_SET_DEBUGREGS _IOW(KVMIO, 0xa2, struct kvm_debugregs) /* - * vcpu version available with KVM_ENABLE_CAP + * vcpu version available with KVM_CAP_ENABLE_CAP * vm version available with KVM_CAP_ENABLE_CAP_VM */ #define KVM_ENABLE_CAP _IOW(KVMIO, 0xa3, struct kvm_enable_cap)
Fix comment for vcpu ioctl version of KVM_ENABLE_CAP. KVM provides ioctl KVM_ENABLE_CAP to allow userspace to enable an extension which is not enabled by default. For vcpu ioctl version, it is available with the capability KVM_CAP_ENABLE_CAP. For vm ioctl version, it is available with the capability KVM_CAP_ENABLE_CAP_VM. Signed-off-by: Binbin Wu <binbin.wu@linux.intel.com> --- include/uapi/linux/kvm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)