| Message ID | 20230904013555.725413-2-tao1.su@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: x86: Fix a WARN in kvm_apic_send_ipi() | expand |
On Mon, Sep 04, 2023 at 09:35:54AM +0800, Tao Su wrote: >According to SDM, bit12 of ICR is no longer BUSY bit but UNUSED bit in >x2APIC mode, which is the only difference of lower ICR between xAPIC and >x2APIC mode. To avoid ambiguity, introduce X2APIC_ICR_UNUSED_12 for >x2APIC mode. > >Signed-off-by: Tao Su <tao1.su@linux.intel.com> Please use scripts/get_maintainer.pl to help create the Cc/To lists. I believe x86 maintainers should be copied for this patch. >--- > arch/x86/include/asm/apicdef.h | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h >index 4b125e5b3187..ea2725738b81 100644 >--- a/arch/x86/include/asm/apicdef.h >+++ b/arch/x86/include/asm/apicdef.h >@@ -78,6 +78,7 @@ > #define APIC_INT_LEVELTRIG 0x08000 > #define APIC_INT_ASSERT 0x04000 > #define APIC_ICR_BUSY 0x01000 >+#define X2APIC_ICR_UNUSED_12 0x01000 > #define APIC_DEST_LOGICAL 0x00800 > #define APIC_DEST_PHYSICAL 0x00000 > #define APIC_DM_FIXED 0x00000 >-- >2.34.1 >
On Mon, Sep 04, 2023 at 10:58:32AM +0800, Chao Gao wrote: > On Mon, Sep 04, 2023 at 09:35:54AM +0800, Tao Su wrote: > >According to SDM, bit12 of ICR is no longer BUSY bit but UNUSED bit in > >x2APIC mode, which is the only difference of lower ICR between xAPIC and > >x2APIC mode. To avoid ambiguity, introduce X2APIC_ICR_UNUSED_12 for > >x2APIC mode. > > > >Signed-off-by: Tao Su <tao1.su@linux.intel.com> > > Please use scripts/get_maintainer.pl to help create the Cc/To lists. > I believe x86 maintainers should be copied for this patch. Ok, I will cc x86 maintainers if keep this patch in the next version. Thanks, Tao > > >--- > > arch/x86/include/asm/apicdef.h | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h > >index 4b125e5b3187..ea2725738b81 100644 > >--- a/arch/x86/include/asm/apicdef.h > >+++ b/arch/x86/include/asm/apicdef.h > >@@ -78,6 +78,7 @@ > > #define APIC_INT_LEVELTRIG 0x08000 > > #define APIC_INT_ASSERT 0x04000 > > #define APIC_ICR_BUSY 0x01000 > >+#define X2APIC_ICR_UNUSED_12 0x01000 > > #define APIC_DEST_LOGICAL 0x00800 > > #define APIC_DEST_PHYSICAL 0x00000 > > #define APIC_DM_FIXED 0x00000 > >-- > >2.34.1 > >
diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h index 4b125e5b3187..ea2725738b81 100644 --- a/arch/x86/include/asm/apicdef.h +++ b/arch/x86/include/asm/apicdef.h @@ -78,6 +78,7 @@ #define APIC_INT_LEVELTRIG 0x08000 #define APIC_INT_ASSERT 0x04000 #define APIC_ICR_BUSY 0x01000 +#define X2APIC_ICR_UNUSED_12 0x01000 #define APIC_DEST_LOGICAL 0x00800 #define APIC_DEST_PHYSICAL 0x00000 #define APIC_DM_FIXED 0x00000
According to SDM, bit12 of ICR is no longer BUSY bit but UNUSED bit in x2APIC mode, which is the only difference of lower ICR between xAPIC and x2APIC mode. To avoid ambiguity, introduce X2APIC_ICR_UNUSED_12 for x2APIC mode. Signed-off-by: Tao Su <tao1.su@linux.intel.com> --- arch/x86/include/asm/apicdef.h | 1 + 1 file changed, 1 insertion(+)