From patchwork Mon Sep 18 06:25:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cao, Yahui" X-Patchwork-Id: 13388831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4999CD13D1 for ; Mon, 18 Sep 2023 06:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239868AbjIRG2X (ORCPT ); Mon, 18 Sep 2023 02:28:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239854AbjIRG17 (ORCPT ); Mon, 18 Sep 2023 02:27:59 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCF7A8F; Sun, 17 Sep 2023 23:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695018474; x=1726554474; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+N6SUzAHNndnwKrBhBL4M+fSkr/yc6MgkvTjYgc1qew=; b=blcPUIxmmea+olr9vB6MbC4u2sIU0xWtNl9zIia1e4he5Pprpk9Bq9n0 Xi5cf3AsoBrBwxad3paZAVLeaKfRdSIwAag076IO2MZwIfcvPHN/1uzp+ mzpve6hu1q9PkYp/74e7pVta3DkGgM55cEWEyHK9/hB73ddHx87E3OgdY 9XCsnZKTOEitotUdi6Ciyj0pN9rw+BARruOiP3m1D8IoIM4Owb3rwTKhp fchbuamlXtAfz2zoeNU+50UP8Wk9nXT1ghKivagaq2uc70/S2weLdyFvt jT0WWgL6k4MFJqEjDqRzWpj1quTEPRsL4VR1rxyx4r2BjBQtoaZCLf44r Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="378488469" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="378488469" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2023 23:27:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10836"; a="815893364" X-IronPort-AV: E=Sophos;i="6.02,155,1688454000"; d="scan'208";a="815893364" Received: from dpdk-yahui-icx1.sh.intel.com ([10.67.111.186]) by fmsmga004.fm.intel.com with ESMTP; 17 Sep 2023 23:27:49 -0700 From: Yahui Cao To: intel-wired-lan@lists.osuosl.org Cc: kvm@vger.kernel.org, netdev@vger.kernel.org, lingyu.liu@intel.com, kevin.tian@intel.com, madhu.chittim@intel.com, sridhar.samudrala@intel.com, alex.williamson@redhat.com, jgg@nvidia.com, yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com, brett.creeley@amd.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com Subject: [PATCH iwl-next v3 01/13] ice: Fix missing legacy 32byte RXDID in the supported bitmap Date: Mon, 18 Sep 2023 06:25:34 +0000 Message-Id: <20230918062546.40419-2-yahui.cao@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230918062546.40419-1-yahui.cao@intel.com> References: <20230918062546.40419-1-yahui.cao@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Xu Ting 32byte legacy descriptor format is preassigned. Commit e753df8fbca5 ("ice: Add support Flex RXD") created a supported RXDIDs bitmap according to DDP package. But it missed the legacy 32byte RXDID since it is not listed in the package. Mark 32byte legacy descriptor format as supported in the supported RXDIDs flags. Signed-off-by: Xu Ting Signed-off-by: Lingyu Liu Signed-off-by: Yahui Cao --- drivers/net/ethernet/intel/ice/ice_virtchnl.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl.c b/drivers/net/ethernet/intel/ice/ice_virtchnl.c index cad237dd8894..3bf95d3c50d3 100644 --- a/drivers/net/ethernet/intel/ice/ice_virtchnl.c +++ b/drivers/net/ethernet/intel/ice/ice_virtchnl.c @@ -2657,10 +2657,13 @@ static int ice_vc_query_rxdid(struct ice_vf *vf) /* Read flexiflag registers to determine whether the * corresponding RXDID is configured and supported or not. - * Since Legacy 16byte descriptor format is not supported, - * start from Legacy 32byte descriptor. + * But the legacy 32byte RXDID is not listed in DDP package, + * add it in the bitmap manually and skip check for it in the loop. + * Legacy 16byte descriptor is not supported. */ - for (i = ICE_RXDID_LEGACY_1; i < ICE_FLEX_DESC_RXDID_MAX_NUM; i++) { + rxdid->supported_rxdids |= BIT(ICE_RXDID_LEGACY_1); + + for (i = ICE_RXDID_FLEX_NIC; i < ICE_FLEX_DESC_RXDID_MAX_NUM; i++) { regval = rd32(hw, GLFLXP_RXDID_FLAGS(i, 0)); if ((regval >> GLFLXP_RXDID_FLAGS_FLEXIFLAG_4N_S) & GLFLXP_RXDID_FLAGS_FLEXIFLAG_4N_M)