| Message ID | 20231216134257.1743345-12-npiggin@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | powerpc: updates, P10, PNV support | expand |
On 16/12/2023 14.42, Nicholas Piggin wrote: > SPRs annotated with SPR_HARNESS can change between consecutive reads > because the test harness code has changed them. Avoid failing the > test in this case. > > [XER was observed to change after the next changeset to use mdelay.] > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > powerpc/sprs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/powerpc/sprs.c b/powerpc/sprs.c > index cd8b472d..01041912 100644 > --- a/powerpc/sprs.c > +++ b/powerpc/sprs.c > @@ -557,7 +557,7 @@ int main(int argc, char **argv) > if (before[i] >> 32) > pass = false; > } > - if (!(sprs[i].type & SPR_ASYNC) && (before[i] != after[i])) > + if (!(sprs[i].type & (SPR_HARNESS|SPR_ASYNC)) && (before[i] != after[i])) > pass = false; I guess you could even squash this into the previous patch. Anyway: Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/powerpc/sprs.c b/powerpc/sprs.c index cd8b472d..01041912 100644 --- a/powerpc/sprs.c +++ b/powerpc/sprs.c @@ -557,7 +557,7 @@ int main(int argc, char **argv) if (before[i] >> 32) pass = false; } - if (!(sprs[i].type & SPR_ASYNC) && (before[i] != after[i])) + if (!(sprs[i].type & (SPR_HARNESS|SPR_ASYNC)) && (before[i] != after[i])) pass = false; if (sprs[i].width == 32 && !(before[i] >> 32) && !(after[i] >> 32))
SPRs annotated with SPR_HARNESS can change between consecutive reads because the test harness code has changed them. Avoid failing the test in this case. [XER was observed to change after the next changeset to use mdelay.] Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- powerpc/sprs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)