| Message ID | 20240112072128.141954-1-chentao@kylinos.cn (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | vfio/fsl-mc: Remove unnecessary free in vfio_set_trigger | expand |
On Fri, 12 Jan 2024 15:21:28 +0800 Kunwu Chan <chentao@kylinos.cn> wrote: > 'irq->name' is initialed by kasprintf, so there is no need > to free it before initializing. This is just as bogus as the vfio-platform version. Thanks, Alex > Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd") > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> > --- > drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > index d62fbfff20b8..31f0716e7ab3 100644 > --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c > @@ -69,7 +69,6 @@ static int vfio_set_trigger(struct vfio_fsl_mc_device *vdev, > hwirq = vdev->mc_dev->irqs[index]->virq; > if (irq->trigger) { > free_irq(hwirq, irq); > - kfree(irq->name); > eventfd_ctx_put(irq->trigger); > irq->trigger = NULL; > }
diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c index d62fbfff20b8..31f0716e7ab3 100644 --- a/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c @@ -69,7 +69,6 @@ static int vfio_set_trigger(struct vfio_fsl_mc_device *vdev, hwirq = vdev->mc_dev->irqs[index]->virq; if (irq->trigger) { free_irq(hwirq, irq); - kfree(irq->name); eventfd_ctx_put(irq->trigger); irq->trigger = NULL; }
'irq->name' is initialed by kasprintf, so there is no need to free it before initializing. Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd") Signed-off-by: Kunwu Chan <chentao@kylinos.cn> --- drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 - 1 file changed, 1 deletion(-)