| Message ID | 20240419161623.45842-3-vsntk18@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add #VC exception handling for AMD SEV-ES | expand |
On Fri, Apr 19, 2024, vsntk18@gmail.com wrote: > From: Vasant Karasulli <vkarasulli@suse.de> > > This enables sharing common definitions across testcases and lib/. > > Signed-off-by: Varad Gautam <varad.gautam@suse.com> > Signed-off-by: Vasant Karasulli <vkarasulli@suse.de> > Reviewed-by: Marc Orr <marcorr@google.com> > --- > {x86 => lib/x86}/svm.h | 0 No, there is far, far more crud in svm.h than belongs in lib/. The architectural definitions and whatnot belong in lib/, but all of the nSVM support code does not. > x86/svm.c | 2 +- > x86/svm_tests.c | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) > rename {x86 => lib/x86}/svm.h (100%) > > diff --git a/x86/svm.h b/lib/x86/svm.h > similarity index 100% > rename from x86/svm.h > rename to lib/x86/svm.h > diff --git a/x86/svm.c b/x86/svm.c > index e715e270..252d5301 100644 > --- a/x86/svm.c > +++ b/x86/svm.c > @@ -2,7 +2,7 @@ > * Framework for testing nested virtualization > */ > > -#include "svm.h" > +#include "x86/svm.h" > #include "libcflat.h" > #include "processor.h" > #include "desc.h" > diff --git a/x86/svm_tests.c b/x86/svm_tests.c > index c81b7465..a180939f 100644 > --- a/x86/svm_tests.c > +++ b/x86/svm_tests.c > @@ -1,4 +1,4 @@ > -#include "svm.h" > +#include "x86/svm.h" > #include "libcflat.h" > #include "processor.h" > #include "desc.h" > -- > 2.34.1 >
On Mi 05-06-24 09:05:28, Sean Christopherson wrote: > On Fri, Apr 19, 2024, vsntk18@gmail.com wrote: > > From: Vasant Karasulli <vkarasulli@suse.de> > > > > This enables sharing common definitions across testcases and lib/. > > > > Signed-off-by: Varad Gautam <varad.gautam@suse.com> > > Signed-off-by: Vasant Karasulli <vkarasulli@suse.de> > > Reviewed-by: Marc Orr <marcorr@google.com> > > --- > > {x86 => lib/x86}/svm.h | 0 > > No, there is far, far more crud in svm.h than belongs in lib/. The architectural > definitions and whatnot belong in lib/, but all of the nSVM support code does not. Ok, I will leave architectural definitions in lib/x86/svm.h, and move the SVM related definitions to x86/svm.h. > > > x86/svm.c | 2 +- > > x86/svm_tests.c | 2 +- > > 3 files changed, 2 insertions(+), 2 deletions(-) > > rename {x86 => lib/x86}/svm.h (100%) > > > > diff --git a/x86/svm.h b/lib/x86/svm.h > > similarity index 100% > > rename from x86/svm.h > > rename to lib/x86/svm.h > > diff --git a/x86/svm.c b/x86/svm.c > > index e715e270..252d5301 100644 > > --- a/x86/svm.c > > +++ b/x86/svm.c > > @@ -2,7 +2,7 @@ > > * Framework for testing nested virtualization > > */ > > > > -#include "svm.h" > > +#include "x86/svm.h" > > #include "libcflat.h" > > #include "processor.h" > > #include "desc.h" > > diff --git a/x86/svm_tests.c b/x86/svm_tests.c > > index c81b7465..a180939f 100644 > > --- a/x86/svm_tests.c > > +++ b/x86/svm_tests.c > > @@ -1,4 +1,4 @@ > > -#include "svm.h" > > +#include "x86/svm.h" > > #include "libcflat.h" > > #include "processor.h" > > #include "desc.h" > > -- > > 2.34.1 > > -- Vasant Karasulli Kernel generalist www.suse.com<http://www.suse.com> [https://www.suse.com/assets/img/social-platforms-suse-logo.png]<http://www.suse.com/> SUSE - Open Source Solutions for Enterprise Servers & Cloud<http://www.suse.com/> Modernize your infrastructure with SUSE Linux Enterprise servers, cloud technology for IaaS, and SUSE's software-defined storage. www.suse.com
diff --git a/x86/svm.h b/lib/x86/svm.h similarity index 100% rename from x86/svm.h rename to lib/x86/svm.h diff --git a/x86/svm.c b/x86/svm.c index e715e270..252d5301 100644 --- a/x86/svm.c +++ b/x86/svm.c @@ -2,7 +2,7 @@ * Framework for testing nested virtualization */ -#include "svm.h" +#include "x86/svm.h" #include "libcflat.h" #include "processor.h" #include "desc.h" diff --git a/x86/svm_tests.c b/x86/svm_tests.c index c81b7465..a180939f 100644 --- a/x86/svm_tests.c +++ b/x86/svm_tests.c @@ -1,4 +1,4 @@ -#include "svm.h" +#include "x86/svm.h" #include "libcflat.h" #include "processor.h" #include "desc.h"