diff mbox series

[kvm-unit-tests] x86: Increase the timeout for the test "vmx_apicv_test"

Message ID 20240701211445.2870218-2-aaronlewis@google.com (mailing list archive)
State New, archived
Headers show
Series [kvm-unit-tests] x86: Increase the timeout for the test "vmx_apicv_test" | expand

Commit Message

Aaron Lewis July 1, 2024, 9:14 p.m. UTC
This test can take over 10 seconds to run on IvyBridge in debug.
Increase the timeout to give this test the time it needs to complete.

Signed-off-by: Aaron Lewis <aaronlewis@google.com>
---
 x86/unittests.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Christopherson July 8, 2024, 4:54 p.m. UTC | #1
On Mon, Jul 01, 2024, Aaron Lewis wrote:
> This test can take over 10 seconds to run on IvyBridge in debug.
> Increase the timeout to give this test the time it needs to complete.

Heh, there's a pretty big gap between 10 seconds and 100 seconds.  Can we tighten
the timeout, e.g. to 30 seconds, without risking false failures on IVB?

> Signed-off-by: Aaron Lewis <aaronlewis@google.com>
> ---
>  x86/unittests.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> index 7c1691a988621..51c063d248e19 100644
> --- a/x86/unittests.cfg
> +++ b/x86/unittests.cfg
> @@ -349,7 +349,7 @@ file = vmx.flat
>  extra_params = -cpu max,+vmx -append "apic_reg_virt_test virt_x2apic_mode_test vmx_basic_vid_test vmx_eoi_virt_test"
>  arch = x86_64
>  groups = vmx
> -timeout = 10
> +timeout = 100
>  
>  [vmx_posted_intr_test]
>  file = vmx.flat
> -- 
> 2.45.2.803.g4e1b14247a-goog
>
Aaron Lewis July 8, 2024, 6:31 p.m. UTC | #2
On Mon, Jul 8, 2024 at 9:54 AM Sean Christopherson <seanjc@google.com> wrote:
>
> On Mon, Jul 01, 2024, Aaron Lewis wrote:
> > This test can take over 10 seconds to run on IvyBridge in debug.
> > Increase the timeout to give this test the time it needs to complete.
>
> Heh, there's a pretty big gap between 10 seconds and 100 seconds.  Can we tighten
> the timeout, e.g. to 30 seconds, without risking false failures on IVB?

Yeah, 30 seconds should work.

>
> > Signed-off-by: Aaron Lewis <aaronlewis@google.com>
> > ---
> >  x86/unittests.cfg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > index 7c1691a988621..51c063d248e19 100644
> > --- a/x86/unittests.cfg
> > +++ b/x86/unittests.cfg
> > @@ -349,7 +349,7 @@ file = vmx.flat
> >  extra_params = -cpu max,+vmx -append "apic_reg_virt_test virt_x2apic_mode_test vmx_basic_vid_test vmx_eoi_virt_test"
> >  arch = x86_64
> >  groups = vmx
> > -timeout = 10
> > +timeout = 100
> >
> >  [vmx_posted_intr_test]
> >  file = vmx.flat
> > --
> > 2.45.2.803.g4e1b14247a-goog
> >
diff mbox series

Patch

diff --git a/x86/unittests.cfg b/x86/unittests.cfg
index 7c1691a988621..51c063d248e19 100644
--- a/x86/unittests.cfg
+++ b/x86/unittests.cfg
@@ -349,7 +349,7 @@  file = vmx.flat
 extra_params = -cpu max,+vmx -append "apic_reg_virt_test virt_x2apic_mode_test vmx_basic_vid_test vmx_eoi_virt_test"
 arch = x86_64
 groups = vmx
-timeout = 10
+timeout = 100
 
 [vmx_posted_intr_test]
 file = vmx.flat