| Message ID | 20241204103042.1904639-9-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | x86: 32-bit cleanups | expand |
+Cc: Ferry On Wed, Dec 4, 2024 at 12:31 PM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > The X86_INTEL_MID code was originally introduced for the > 32-bit Moorestown/Medfield/Clovertrail platform, later the 64-bit > Merrifield/Moorefield variant got added, but the final variant got --> variants were > Morganfield/Broxton 14nm chips were canceled before they hit > the market. Inaccurate. "Broxton for Mobile", and not "Broxton" in general. > To help users understand what the option actually refers to, > update the help text, and make it a hard dependency on 64-bit > kernels. While they could theoretically run a 32-bit kernel, > the devices originally shipped with 64-bit one in 2015, so that > was proabably never tested. probably It's all other way around (from SW point of view). For unknown reasons Intel decided to release only 32-bit SW and it became the only thing that was heavily tested (despite misunderstanding by some developers that pointed finger to the HW without researching the issue that appears to be purely software in a few cases) _that_ time. Starting ca. 2017 I enabled 64-bit for Merrifield and from then it's being used by both 32- and 64-bit builds. I'm totally fine to drop 32-bit defaults for Merrifield/Moorefield, but let's hear Ferry who might/may still have a use case for that. ... > - Moorestown MID devices FTR, a year or so ago it was a (weak) interest to revive Medfield, but I think it would require too much work even for the person who is quite familiar with HW, U-Boot, and Linux kernel, so it is most unlikely to happen. ... > Select to build a kernel capable of supporting Intel MID (Mobile > Internet Device) platform systems which do not have the PCI legacy > - interfaces. If you are building for a PC class system say N here. > + interfaces. > + > + The only supported devices are the 22nm Merrified (Z34xx) and > + Moorefield (Z35xx) SoC used in Android devices such as the > + Asus Zenfone 2, Asus FonePad 8 and Dell Venue 7. The list is missing the Intel Edison DIY platform which is probably the main user of Intel MID kernels nowadays. ... > - Intel MID platforms are based on an Intel processor and chipset which > - consume less power than most of the x86 derivatives. Why remove this? AFAIK it states the truth.
On Wed, Dec 4, 2024, at 19:55, Andy Shevchenko wrote: > +Cc: Ferry > > On Wed, Dec 4, 2024 at 12:31 PM Arnd Bergmann <arnd@kernel.org> wrote: >> >> From: Arnd Bergmann <arnd@arndb.de> >> >> The X86_INTEL_MID code was originally introduced for the >> 32-bit Moorestown/Medfield/Clovertrail platform, later the 64-bit >> Merrifield/Moorefield variant got added, but the final > > variant got --> variants were Fixed >> Morganfield/Broxton 14nm chips were canceled before they hit >> the market. > > Inaccurate. "Broxton for Mobile", and not "Broxton" in general. Changed to "but the final Morganfield 14nm platform was canceled before it hit the market" >> To help users understand what the option actually refers to, >> update the help text, and make it a hard dependency on 64-bit >> kernels. While they could theoretically run a 32-bit kernel, >> the devices originally shipped with 64-bit one in 2015, so that >> was proabably never tested. > > probably Fixed. > It's all other way around (from SW point of view). For unknown reasons > Intel decided to release only 32-bit SW and it became the only thing > that was heavily tested (despite misunderstanding by some developers > that pointed finger to the HW without researching the issue that > appears to be purely software in a few cases) _that_ time. Starting > ca. 2017 I enabled 64-bit for Merrifield and from then it's being used > by both 32- and 64-bit builds. > > I'm totally fine to drop 32-bit defaults for Merrifield/Moorefield, > but let's hear Ferry who might/may still have a use case for that. Ok. I tried to find the oldest Android image and saw it used a 64-bit kernel, but that must have been after your work then. > >> - Moorestown MID devices > > FTR, a year or so ago it was a (weak) interest to revive Medfield, but > I think it would require too much work even for the person who is > quite familiar with HW, U-Boot, and Linux kernel, so it is most > unlikely to happen. Ok. >> + >> + The only supported devices are the 22nm Merrified (Z34xx) and >> + Moorefield (Z35xx) SoC used in Android devices such as the >> + Asus Zenfone 2, Asus FonePad 8 and Dell Venue 7. > > The list is missing the Intel Edison DIY platform which is probably > the main user of Intel MID kernels nowadays. Ah, that explains a lot ;-) Changed now to The only supported devices are the 22nm Merrified (Z34xx) and Moorefield (Z35xx) SoC used in the Intel Edison board and a small number of Android devices such as the Asus Zenfone 2, Asus FonePad 8 and Dell Venue 7. > ... > >> - Intel MID platforms are based on an Intel processor and chipset which >> - consume less power than most of the x86 derivatives. > > Why remove this? AFAIK it states the truth. It seemed irrelevant for users that configure the kernel. I've put it back now. Thanks for the review! Arnd
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index d8a8bf9ea9b9..fa6dd9ec4bdf 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -544,12 +544,12 @@ config X86_EXTENDED_PLATFORM RDC R-321x SoC SGI 320/540 (Visual Workstation) STA2X11-based (e.g. Northville) - Moorestown MID devices 64-bit platforms (CONFIG_64BIT=y): Numascale NumaChip ScaleMP vSMP SGI Ultraviolet + Merrifield/Moorefield MID devices If you have one of these systems, or if you want to build a generic distribution kernel, say Y here - otherwise say N. @@ -621,11 +621,11 @@ config X86_INTEL_CE boxes and media devices. config X86_INTEL_MID - bool "Intel MID platform support" + bool "Intel Z34xx/Z35xx MID platform support" depends on X86_EXTENDED_PLATFORM depends on X86_PLATFORM_DEVICES depends on PCI - depends on X86_64 || (PCI_GOANY && X86_32) + depends on X86_64 depends on X86_IO_APIC select I2C select DW_APB_TIMER @@ -633,10 +633,14 @@ config X86_INTEL_MID help Select to build a kernel capable of supporting Intel MID (Mobile Internet Device) platform systems which do not have the PCI legacy - interfaces. If you are building for a PC class system say N here. + interfaces. + + The only supported devices are the 22nm Merrified (Z34xx) and + Moorefield (Z35xx) SoC used in Android devices such as the + Asus Zenfone 2, Asus FonePad 8 and Dell Venue 7. - Intel MID platforms are based on an Intel processor and chipset which - consume less power than most of the x86 derivatives. + If you are building for a PC class system or non-MID tablet + SoCs like Bay Trail (Z36xx/Z37xx), say N here. config X86_INTEL_QUARK bool "Intel Quark platform support" diff --git a/arch/x86/kernel/head32.c b/arch/x86/kernel/head32.c index de001b2146ab..4f69239556e4 100644 --- a/arch/x86/kernel/head32.c +++ b/arch/x86/kernel/head32.c @@ -65,9 +65,6 @@ asmlinkage __visible void __init __noreturn i386_start_kernel(void) /* Call the subarch specific early setup function */ switch (boot_params.hdr.hardware_subarch) { - case X86_SUBARCH_INTEL_MID: - x86_intel_mid_early_setup(); - break; case X86_SUBARCH_CE4100: x86_ce4100_early_setup(); break;