diff mbox series

[04/20] KVM: selftests: Drop stale srandom() initialization from dirty_log_test

Message ID 20241214010721.2356923-5-seanjc@google.com (mailing list archive)
State New
Headers show
Series [01/20] KVM: selftests: Support multiple write retires in dirty_log_test | expand

Commit Message

Sean Christopherson Dec. 14, 2024, 1:07 a.m. UTC
Drop an srandom() initialization that was leftover from the conversion to
use selftests' guest_random_xxx() APIs.

Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 tools/testing/selftests/kvm/dirty_log_test.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Maxim Levitsky Dec. 17, 2024, 11:59 p.m. UTC | #1
On Fri, 2024-12-13 at 17:07 -0800, Sean Christopherson wrote:
> Drop an srandom() initialization that was leftover from the conversion to
> use selftests' guest_random_xxx() APIs.
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>  tools/testing/selftests/kvm/dirty_log_test.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c
> index d9911e20337f..55a744373c80 100644
> --- a/tools/testing/selftests/kvm/dirty_log_test.c
> +++ b/tools/testing/selftests/kvm/dirty_log_test.c
> @@ -891,8 +891,6 @@ int main(int argc, char *argv[])
>  	pr_info("Test iterations: %"PRIu64", interval: %"PRIu64" (ms)\n",
>  		p.iterations, p.interval);
>  
> -	srandom(time(0));
> -
>  	if (host_log_mode_option == LOG_MODE_ALL) {
>  		/* Run each log mode */
>  		for (i = 0; i < LOG_MODE_NUM; i++) {

Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

Best regards,
	Maxim Levitsky
diff mbox series

Patch

diff --git a/tools/testing/selftests/kvm/dirty_log_test.c b/tools/testing/selftests/kvm/dirty_log_test.c
index d9911e20337f..55a744373c80 100644
--- a/tools/testing/selftests/kvm/dirty_log_test.c
+++ b/tools/testing/selftests/kvm/dirty_log_test.c
@@ -891,8 +891,6 @@  int main(int argc, char *argv[])
 	pr_info("Test iterations: %"PRIu64", interval: %"PRIu64" (ms)\n",
 		p.iterations, p.interval);
 
-	srandom(time(0));
-
 	if (host_log_mode_option == LOG_MODE_ALL) {
 		/* Run each log mode */
 		for (i = 0; i < LOG_MODE_NUM; i++) {