diff mbox series

[08/29] KVM: x86/mmu: Do not enable page track for TD guest

Message ID	20250226195529.2314580-9-pbonzini@redhat.com (mailing list archive)
State	New
Headers	show Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6882525E466 for <kvm@vger.kernel.org>; Wed, 26 Feb 2025 19:55:48 +0000 (UTC) From: Paolo Bonzini <pbonzini@redhat.com> To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com, Yan Zhao <yan.y.zhao@intel.com>, Rick Edgecombe <rick.p.edgecombe@intel.com>, Binbin Wu <binbin.wu@linux.intel.com>, Yuan Yao <yuan.yao@linux.intel.com> Subject: [PATCH 08/29] KVM: x86/mmu: Do not enable page track for TD guest Date: Wed, 26 Feb 2025 14:55:08 -0500 Message-ID: <20250226195529.2314580-9-pbonzini@redhat.com> In-Reply-To: <20250226195529.2314580-1-pbonzini@redhat.com> References: <20250226195529.2314580-1-pbonzini@redhat.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit
Series	TDX MMU part 2 \| expand [v3,00/29] TDX MMU part 2 [01/29] x86/virt/tdx: Add SEAMCALL wrapper tdh_mem_sept_add() to add SEPT pages [02/29] x86/virt/tdx: Add SEAMCALL wrappers to add TD private pages [03/29] x86/virt/tdx: Add SEAMCALL wrappers to manage TDX TLB tracking [04/29] x86/virt/tdx: Add SEAMCALL wrappers to remove a TD private page [05/29] x86/virt/tdx: Add SEAMCALL wrappers for TD measurement of initial contents [06/29] KVM: x86/mmu: Implement memslot deletion for TDX [07/29] KVM: x86/tdp_mmu: Add a helper function to walk down the TDP MMU [08/29] KVM: x86/mmu: Do not enable page track for TD guest [09/29] KVM: VMX: Split out guts of EPT violation to common/exposed function [10/29] KVM: VMX: Teach EPT violation helper about private mem [11/29] KVM: TDX: Add accessors VMX VMCS helpers [12/29] KVM: TDX: Add load_mmu_pgd method for TDX [13/29] KVM: TDX: Set gfn_direct_bits to shared bit [14/29] KVM: TDX: Require TDP MMU, mmio caching and EPT A/D bits for TDX [15/29] KVM: x86/mmu: Add setter for shadow_mmio_value [16/29] KVM: TDX: Set per-VM shadow_mmio_value to 0 [17/29] KVM: TDX: Handle TLB tracking for TDX [18/29] KVM: TDX: Implement hooks to propagate changes of TDP MMU mirror page table [19/29] KVM: TDX: Implement hook to get max mapping level of private pages [20/29] KVM: x86/mmu: Bail out kvm_tdp_map_page() when VM dead [21/29] KVM: x86/mmu: Export kvm_tdp_map_page() [22/29] KVM: TDX: Add an ioctl to create initial guest memory [23/29] KVM: TDX: Finalize VM initialization [24/29] KVM: TDX: Handle vCPU dissociation [25/29] KVM: Add parameter "kvm" to kvm_cpu_dirty_log_size() and its callers [26/29] KVM: x86/mmu: Add parameter "kvm" to kvm_mmu_page_ad_need_write_protect() [27/29] KVM: x86: Make cpu_dirty_log_size a per-VM value [28/29] KVM: TDX: Skip updating CPU dirty logging request for TDs [29/29] KVM: TDX: Handle SEPT zap error due to page add error in premap

Commit Message

Paolo Bonzini Feb. 26, 2025, 7:55 p.m. UTC

From: Yan Zhao <yan.y.zhao@intel.com>

Fail kvm_page_track_write_tracking_enabled() if VM type is TDX to make the
external page track user fail in kvm_page_track_register_notifier() since
TDX does not support write protection and hence page track.

No need to fail KVM internal users of page track (i.e. for shadow page),
because TDX is always with EPT enabled and currently TDX module does not
emulate and send VMLAUNCH/VMRESUME VMExits to VMM.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>
Cc: Yuan Yao <yuan.yao@linux.intel.com>
Message-ID: <20241112073515.22028-1-yan.y.zhao@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 arch/x86/kvm/mmu/page_track.c | 3 +++
 1 file changed, 3 insertions(+)

diff mbox series

Patch

diff --git a/arch/x86/kvm/mmu/page_track.c b/arch/x86/kvm/mmu/page_track.c
index 561c331fd6ec..1b17b12393a8 100644
--- a/arch/x86/kvm/mmu/page_track.c
+++ b/arch/x86/kvm/mmu/page_track.c
@@ -172,6 +172,9 @@  static int kvm_enable_external_write_tracking(struct kvm *kvm)
 	struct kvm_memory_slot *slot;
 	int r = 0, i, bkt;
 
+	if (kvm->arch.vm_type == KVM_X86_TDX_VM)
+		return -EOPNOTSUPP;
+
 	mutex_lock(&kvm->slots_arch_lock);
 
 	/*