| Message ID | 20250307180337.14811-8-philmd@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | hw/vfio: Build various objects once | expand |
On 3/7/25 10:03, Philippe Mathieu-Daudé wrote: > display.c doesn't rely on target specific definitions, > move it to system_ss[] to build it once. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > hw/vfio/meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/vfio/meson.build b/hw/vfio/meson.build > index fea6dbe88cd..96e342aa8cb 100644 > --- a/hw/vfio/meson.build > +++ b/hw/vfio/meson.build > @@ -5,7 +5,6 @@ vfio_ss.add(files( > )) > vfio_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr.c')) > vfio_ss.add(when: 'CONFIG_VFIO_PCI', if_true: files( > - 'display.c', > 'pci-quirks.c', > 'pci.c', > )) > @@ -28,3 +27,6 @@ system_ss.add(when: 'CONFIG_VFIO', if_true: files( > system_ss.add(when: ['CONFIG_VFIO', 'CONFIG_IOMMUFD'], if_true: files( > 'iommufd.c', > )) > +system_ss.add(when: 'CONFIG_VFIO_PCI', if_true: files( > + 'display.c', > +)) Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
On 3/7/25 19:03, Philippe Mathieu-Daudé wrote: > display.c doesn't rely on target specific definitions, > move it to system_ss[] to build it once. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > hw/vfio/meson.build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/vfio/meson.build b/hw/vfio/meson.build > index fea6dbe88cd..96e342aa8cb 100644 > --- a/hw/vfio/meson.build > +++ b/hw/vfio/meson.build > @@ -5,7 +5,6 @@ vfio_ss.add(files( > )) > vfio_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr.c')) > vfio_ss.add(when: 'CONFIG_VFIO_PCI', if_true: files( > - 'display.c', > 'pci-quirks.c', > 'pci.c', > )) > @@ -28,3 +27,6 @@ system_ss.add(when: 'CONFIG_VFIO', if_true: files( > system_ss.add(when: ['CONFIG_VFIO', 'CONFIG_IOMMUFD'], if_true: files( > 'iommufd.c', > )) > +system_ss.add(when: 'CONFIG_VFIO_PCI', if_true: files( > + 'display.c', > +))
diff --git a/hw/vfio/meson.build b/hw/vfio/meson.build index fea6dbe88cd..96e342aa8cb 100644 --- a/hw/vfio/meson.build +++ b/hw/vfio/meson.build @@ -5,7 +5,6 @@ vfio_ss.add(files( )) vfio_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr.c')) vfio_ss.add(when: 'CONFIG_VFIO_PCI', if_true: files( - 'display.c', 'pci-quirks.c', 'pci.c', )) @@ -28,3 +27,6 @@ system_ss.add(when: 'CONFIG_VFIO', if_true: files( system_ss.add(when: ['CONFIG_VFIO', 'CONFIG_IOMMUFD'], if_true: files( 'iommufd.c', )) +system_ss.add(when: 'CONFIG_VFIO_PCI', if_true: files( + 'display.c', +))
display.c doesn't rely on target specific definitions, move it to system_ss[] to build it once. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- hw/vfio/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)