From patchwork Wed Jun 10 12:30:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Goldish X-Patchwork-Id: 29274 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5ACUASF027178 for ; Wed, 10 Jun 2009 12:30:10 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755967AbZFJMaG (ORCPT ); Wed, 10 Jun 2009 08:30:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751995AbZFJMaG (ORCPT ); Wed, 10 Jun 2009 08:30:06 -0400 Received: from mx1.redhat.com ([66.187.233.31]:33856 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755967AbZFJMaF (ORCPT ); Wed, 10 Jun 2009 08:30:05 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n5ACU6FB027583; Wed, 10 Jun 2009 08:30:06 -0400 Received: from mail05.corp.redhat.com (zmail05.collab.prod.int.phx2.redhat.com [10.5.5.46]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n5ACU3qu020635; Wed, 10 Jun 2009 08:30:03 -0400 Date: Wed, 10 Jun 2009 08:30:02 -0400 (EDT) From: Michael Goldish To: Lucas Meneghel Rodrigues Cc: kvm@vger.kernel.org, autotest@test.kernel.org Message-ID: <226342743.1664451244637002972.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> In-Reply-To: <647673181.1664371244636896223.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Subject: Re: [Autotest] [KVM-AUTOTEST PATCH 4/4] Fix bad logging calls MIME-Version: 1.0 X-Originating-IP: [10.5.5.72] X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Looks fine to me. ----- Original Message ----- From: "Lucas Meneghel Rodrigues" To: autotest@test.kernel.org Cc: kvm@vger.kernel.org Sent: Tuesday, June 9, 2009 7:33:29 PM (GMT+0200) Auto-Detected Subject: [Autotest] [KVM-AUTOTEST PATCH 4/4] Fix bad logging calls During the conversion of kvm autotest to upstream coding standards, some bad logging calls were left behind. This patch fixes them. Signed-off-by: Lucas Meneghel Rodrigues --- client/tests/kvm/kvm_utils.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/client/tests/kvm/kvm_utils.py b/client/tests/kvm/kvm_utils.py index 0f4c770..70a49c9 100644 --- a/client/tests/kvm/kvm_utils.py +++ b/client/tests/kvm/kvm_utils.py @@ -304,7 +304,7 @@ class kvm_spawn: # Print some debugging info if match == None and self.poll() != 0: - logging.debug("Timeout elapsed or process terminated. Output:", + logging.debug("Timeout elapsed or process terminated. Output:%s", format_str_for_message(data.strip())) return (match, data) @@ -465,8 +465,8 @@ class kvm_spawn: # Print some debugging info if status != 0: - logging.debug("Command failed; status: %d, output:" % status \ - + format_str_for_message(output.strip())) + logging.debug("Command failed; status: %d, output:%s", status, + format_str_for_message(output.strip())) return (status, output)