| Message ID | 3f268f096b7427ffbf39358d8559d884c85bec88.1730118186.git.kai.huang@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | TDX host: metadata reading tweaks, bug fix and info dump | expand |
On 28.10.24 г. 14:41 ч., Kai Huang wrote: > Compiler attributes __packed and __aligned, and DECLARE_FLEX_ARRAY() are > currently used in arch/x86/virt/vmx/tdx/tdx.h, but the relevant headers > are not included explicitly. > > There's no build issue in the current code since this "tdx.h" is only > included by arch/x86/virt/vmx/tdx/tdx.c and it includes bunch of other > <linux/xxx.h> before including "tdx.h". But for the better explicitly > include the relevant headers to "tdx.h". Also include <linux/types.h> > for basic variable types like u16. > > Signed-off-by: Kai Huang <kai.huang@intel.com> Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>
Kai Huang wrote: > Compiler attributes __packed and __aligned, and DECLARE_FLEX_ARRAY() are > currently used in arch/x86/virt/vmx/tdx/tdx.h, but the relevant headers > are not included explicitly. > > There's no build issue in the current code since this "tdx.h" is only > included by arch/x86/virt/vmx/tdx/tdx.c and it includes bunch of other > <linux/xxx.h> before including "tdx.h". But for the better explicitly > include the relevant headers to "tdx.h". Also include <linux/types.h> > for basic variable types like u16. > > Signed-off-by: Kai Huang <kai.huang@intel.com> Makes sense Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h index ec879d54eb5c..b1d705c3ab2a 100644 --- a/arch/x86/virt/vmx/tdx/tdx.h +++ b/arch/x86/virt/vmx/tdx/tdx.h @@ -2,6 +2,9 @@ #ifndef _X86_VIRT_TDX_H #define _X86_VIRT_TDX_H +#include <linux/types.h> +#include <linux/compiler_attributes.h> +#include <linux/stddef.h> #include <linux/bits.h> /*
Compiler attributes __packed and __aligned, and DECLARE_FLEX_ARRAY() are currently used in arch/x86/virt/vmx/tdx/tdx.h, but the relevant headers are not included explicitly. There's no build issue in the current code since this "tdx.h" is only included by arch/x86/virt/vmx/tdx/tdx.c and it includes bunch of other <linux/xxx.h> before including "tdx.h". But for the better explicitly include the relevant headers to "tdx.h". Also include <linux/types.h> for basic variable types like u16. Signed-off-by: Kai Huang <kai.huang@intel.com> --- arch/x86/virt/vmx/tdx/tdx.h | 3 +++ 1 file changed, 3 insertions(+)