From patchwork Thu May 7 12:34:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jes Sorensen X-Patchwork-Id: 22311 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n47CYDwQ007406 for ; Thu, 7 May 2009 12:34:13 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755703AbZEGMeJ (ORCPT ); Thu, 7 May 2009 08:34:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756258AbZEGMeI (ORCPT ); Thu, 7 May 2009 08:34:08 -0400 Received: from relay3.sgi.com ([192.48.156.57]:55270 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753230AbZEGMeH (ORCPT ); Thu, 7 May 2009 08:34:07 -0400 Received: from eye3.emea.sgi.com (eye3.emea.sgi.com [144.253.156.24]) by relay3.corp.sgi.com (Postfix) with ESMTP id 799B6AC01E; Thu, 7 May 2009 05:34:05 -0700 (PDT) Message-ID: <4A02D539.6040705@sgi.com> Date: Thu, 07 May 2009 14:34:01 +0200 From: Jes Sorensen User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Avi Kivity CC: Anthony Liguori , "Zhang, Xiantao" , "kvm-ia64@vger.kernel.org" , "kvm@vger.kernel.org" , qemu-devel Subject: Re: [patch] fix qemu-kvm to build when gdbstub is disabled References: <4A01AFE8.3020008@sgi.com> <706158FABBBA044BAD4FE898A02E4BC236AC6F59@pdsmsx503.ccr.corp.intel.com> <4A02AA81.90809@redhat.com> <4A02BD27.5050401@siemens.com> <4A02BF59.6030103@redhat.com> In-Reply-To: <4A02BF59.6030103@redhat.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Avi Kivity wrote: > I agree, unless > > - we want to make gdbstub support configurable (don't see any > overwhelming reason for this, but maybe others do) > - we want to merge ia64 kvm support upstream, and don't want to impose > gdbstub support (though I'd recommend properly implementing gdbstub) > > In any case, I'm okay with dropping the check upstream and applying the > local fixup. Hi, Here's a patch that fixes the #ifndef to make it the #ifdef as it was intended. I am quite fine with us trying to drop all the #ifdefs and introduce noop wrappers for archs that do not provide the gdbstubs (ie. ia64), but to start with we better just fix the #ifndef to make it behave like it was originally intended. Cheers, Jes Fix incorrect #ifndef for CONFIG_GETSTUB, which should have been an #ifdef. Signed-off-by: Jes Sorensen --- vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu/vl.c =================================================================== --- qemu.orig/vl.c +++ qemu/vl.c @@ -4350,7 +4350,7 @@ } if (cpu_can_run(env)) ret = qemu_cpu_exec(env); -#ifndef CONFIG_GDBSTUB +#ifdef CONFIG_GDBSTUB if (ret == EXCP_DEBUG) { gdb_set_stop_cpu(env); debug_requested = 1;