| Message ID | 4A2E2052.7050304@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> > Hi, > > This test will boot VMs until one of them becomes unresponsive, and > records the maximum number of VMs successfully started. > > Can you clarify what this test is exactly testing? Is it any of the tests on http://kvm.et.redhat.com/page/KVM-Autotest/TODO (if not, please add it). Are you expecting OOM? Or some VMs to go into swap? Are the VMs completely idle, except for responding to SSH? Are you going to integrate KSM into this? TIA, Y. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
----- "Yaniv Kaul" <ykaul@redhat.com> wrote: > > > > Hi, > > > > This test will boot VMs until one of them becomes unresponsive, and > > > records the maximum number of VMs successfully started. > > > > > Can you clarify what this test is exactly testing? Is it any of the > tests on http://kvm.et.redhat.com/page/KVM-Autotest/TODO (if not, > please add it). The test is in the wiki -- I added it months ago but didn't write it: 'Write a test which adds VMs until one of them becomes unresponsive, and records the maximum number of VMs successfully started. [jasowang]' > Are you expecting OOM? Or some VMs to go into swap? Are the VMs > completely idle, except for responding to SSH? > Are you going to integrate KSM into this? In my review of the patch I forgot to mention running load on the VMs. This can be done easily by using 2 sessions per guest (or running in the background of a single session, but I prefer the former), and should be made user configurable via the config file. I'm not sure about the other things you mentioned -- what should we do about OOM and swap usage? Fail the test? Limit the number of VMs? And KSM sounds like a good idea, but I'm not sure it should be set up by the framework. Maybe it should be pre-setup on some of the hosts, so eventually some hosts will test with KSM and some without, and the framework can be unaware of that. We can find a way to add that information to the results database (like we currently add the KVM version). Another option is to write a KSM setup test, like kvm_install, that will either run or not run before all other tests, depending on the control file. > > > TIA, > Y. > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/09/2009 11:41 AM, Yolkfull Chow wrote: > > Hi, > > This test will boot VMs until one of them becomes unresponsive, and > records the maximum number of VMs successfully started. > > Hello, Some more comments (in addition to previous comments by others) 1. Do not just send monitor command "quit" but use vm.destroy * This was mentioned by Michael, but in a different context. 2. Do not destroy main_vm (or vm1). We may want to run other tests on it. 3. You can use enumerate(vms) instead of looking for vm with index. 4. It would be nice to close all ssh sessions too. Regards, Uri. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/09/2009 08:45 PM, Uri Lublin wrote: > On 06/09/2009 11:41 AM, Yolkfull Chow wrote: >> >> Hi, >> >> This test will boot VMs until one of them becomes unresponsive, and >> records the maximum number of VMs successfully started. >> >> > > Hello, > > Some more comments (in addition to previous comments by others) > 1. Do not just send monitor command "quit" but use vm.destroy > * This was mentioned by Michael, but in a different context. > 2. Do not destroy main_vm (or vm1). We may want to run other tests on it. > 3. You can use enumerate(vms) instead of looking for vm with index. > 4. It would be nice to close all ssh sessions too. OK, I will do modification according to your comments, thank you so much. :) Best Regards, Yolkfull > > Regards, > Uri. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py index cccc48e..7d00277 100644 --- a/client/tests/kvm/kvm_tests.py +++ b/client/tests/kvm/kvm_tests.py @@ -466,3 +466,70 @@ def run_linux_s3(test, params, env): logging.info("VM resumed after S3") session.close() + +def run_boot_vms(tests, params, env): + """ + Boots VMs until one of them becomes unresponsive, and records the maximum + number of VMs successfully started: + 1) boot the first vm + 2) boot the second vm cloned from the first vm, check whether it boots up + and all booted vms can ssh-login + 3) go on until cannot create VM anymore or cannot allocate memory for VM + + @param test: kvm test object + @param params: Dictionary with the test parameters + @param env: Dictionary with test environment. + """ + # boot the first vm + vm1 = kvm_utils.env_get_vm(env, params.get("main_vm")) + + if not vm1: + raise error.TestError("VM object not found in environment") + if not vm1.is_alive(): + raise error.TestError("VM seems to be dead; Test requires a living VM") + + logging.info("Waiting for first guest to be up...") + + vm1_session = kvm_utils.wait_for(vm1.ssh_login, 240, 0, 2) + if not vm1_session: + raise error.TestFail("Could not log into first guest") + + num = 1 + vms = [vm1] + sessions = [vm1_session] + + # boot the VMs + while True: + try: + num += 1 + vm_name = "vm" + str(num) + + # clone vm according to the first one + curr_vm = vm1.clone(vm_name) + logging.info(" Booting the %dth guest" % num) + if not curr_vm.create(): + raise error.TestFail("Cannot boot vm anylonger") + + curr_vm_session = kvm_utils.wait_for(curr_vm.ssh_login, 240, 0, 2) + + if not curr_vm_session: + curr_vm.send_monitor_cmd("quit") + raise error.TestFail("Could not log into %dth guest" % num) + + logging.info(" %dth guest boots up successfully" % num) + sessions.append(curr_vm_session) + vms.append(curr_vm) + + # check whether all previous ssh sessions are responsive + for vm_session in sessions: + if not vm_session.is_responsive(): + logging.error("%dth guest's session is not responsive" \ + % (sessions.index(vm_session) + 1)) + + except (error.TestFail, OSError): + for vm in vms: + logging.info("Shut down the %dth guest" % (vms.index(vm) + 1)) + vm.destroy(gracefully = params.get("kill_vm_gracefully") \ + == "yes") + logging.info("Total number booted successfully: %d" % (num - 1)) + break