From patchwork Tue Jul 21 05:55:13 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?THVrw6HFoSBEb2t0b3I=?= X-Patchwork-Id: 36457 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n6L5tNeH006261 for ; Tue, 21 Jul 2009 05:55:23 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754623AbZGUFzU (ORCPT ); Tue, 21 Jul 2009 01:55:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754558AbZGUFzU (ORCPT ); Tue, 21 Jul 2009 01:55:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]:56510 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754521AbZGUFzT (ORCPT ); Tue, 21 Jul 2009 01:55:19 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n6L5tHHB024873; Tue, 21 Jul 2009 01:55:17 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n6L5tFhb031012; Tue, 21 Jul 2009 01:55:15 -0400 Received: from [10.34.33.254] (dhcp-lab-254.englab.brq.redhat.com [10.34.33.254]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n6L5tEoD024579; Tue, 21 Jul 2009 01:55:14 -0400 Message-ID: <4A655841.9040500@redhat.com> Date: Tue, 21 Jul 2009 07:55:13 +0200 From: =?ISO-8859-15?Q?Luk=E1=A8_Doktor?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Arnd Bergmann CC: KVM list , Lucas Meneghel Rodrigues Subject: Re: [KVM_AUTOTEST] set English environment References: <4A55CB8B.4010907@redhat.com> <200907210209.00154.arnd@arndb.de> In-Reply-To: <200907210209.00154.arnd@arndb.de> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Dne 21.7.2009 02:09, Arnd Bergmann napsal(a): > On Thursday 09 July 2009, Lukáš Doktor wrote: >> --- orig/client/tests/kvm/control 2009-07-08 13:18:07.000000000 +0200 >> +++ new/client/tests/kvm/control 2009-07-09 12:32:32.000000000 +0200 >> @@ -45,6 +45,8 @@ Each test is appropriately documented on >> >> import sys, os >> >> +# set English environment >> +os.environ['LANG'] = 'en_US.UTF-8' >> # enable modules import from current directory (tests/kvm) >> pwd = os.path.join(os.environ['AUTODIR'],'tests/kvm') >> sys.path.append(pwd) > > LANG can still be overridden with LC_ALL. For a well-defined environment, > best set LC_ALL='C'. This will also set other i18n settings and works > on systems that don't come with UTF-8 enabled. > > Arnd<>< Yes, you are right. LC_ALL='C' is more clean way to do. Attached the fixed patch. --- orig/client/tests/kvm/control 2009-07-08 13:18:07.000000000 +0200 +++ new/client/tests/kvm/control 2009-07-09 12:32:32.000000000 +0200 @@ -45,6 +45,8 @@ Each test is appropriately documented on import sys, os +# set English environment +os.environ['LC_ALL'] = 'C' # enable modules import from current directory (tests/kvm) pwd = os.path.join(os.environ['AUTODIR'],'tests/kvm') sys.path.append(pwd)