From patchwork Fri Aug 7 12:31:18 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Lalancette X-Patchwork-Id: 39914 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n77CVO0c025075 for ; Fri, 7 Aug 2009 12:31:24 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757792AbZHGMbU (ORCPT ); Fri, 7 Aug 2009 08:31:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757790AbZHGMbU (ORCPT ); Fri, 7 Aug 2009 08:31:20 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35596 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757258AbZHGMbT (ORCPT ); Fri, 7 Aug 2009 08:31:19 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n77CVK01003727 for ; Fri, 7 Aug 2009 08:31:20 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n77CVJ6Z023436; Fri, 7 Aug 2009 08:31:20 -0400 Received: from localhost.localdomain (vpn-12-144.rdu.redhat.com [10.11.12.144]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n77CVI59013923; Fri, 7 Aug 2009 08:31:19 -0400 Message-ID: <4A7C1E96.3060200@redhat.com> Date: Fri, 07 Aug 2009 14:31:18 +0200 From: Chris Lalancette User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Avi Kivity CC: kvm@vger.kernel.org Subject: [PATCH]: Always use KVM_VERSION to build version number X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Avi, Trying to use libvirt with development snapshots of qemu-kvm is a bit problematic. The trouble is that for all development snapshots, the value that gets placed into this string: QEMU PC emulator version 0.10.0 (kvm-devel), Copyright (c) 2003-2008 Is always kvm-devel. That means we can't tell if this is a kvm development snapshot built yesterday, or 6 months ago, which means that in turn we can't tell what features are available. While we can always tell people building their own qemu to force it by echoing a value into KVM_VERSION, it would be much better if this were done by default. Something like kvm-88-devel, which would signify that this the development happening after kvm-88, leading towards kvm-89. Would you accept something like the patch below, which would require you to edit the KVM_VERSION file twice during a release (once right before the release, to change it to kvm-89, and once right after the release to change it back to kvm-89-devel)? Signed-off-by: Chris Lalancette diff --git a/KVM_VERSION b/KVM_VERSION new file mode 100644 index 0000000..efd3e0e --- /dev/null +++ b/KVM_VERSION @@ -0,0 +1 @@ +kvm-88-devel