From patchwork Wed Jul 20 17:41:02 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 992812 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p6KHfELL014185 for ; Wed, 20 Jul 2011 17:41:14 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712Ab1GTRlL (ORCPT ); Wed, 20 Jul 2011 13:41:11 -0400 Received: from david.siemens.de ([192.35.17.14]:27937 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302Ab1GTRlK (ORCPT ); Wed, 20 Jul 2011 13:41:10 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id p6KHf38B010699; Wed, 20 Jul 2011 19:41:03 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id p6KHf2mA016012; Wed, 20 Jul 2011 19:41:03 +0200 Message-ID: <4E27132E.6080504@siemens.com> Date: Wed, 20 Jul 2011 19:41:02 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Avi Kivity CC: qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: Re: [RFC v5 00/86] Memory API References: <1311180636-17012-1-git-send-email-avi@redhat.com> In-Reply-To: <1311180636-17012-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Wed, 20 Jul 2011 17:41:14 +0000 (UTC) On 2011-07-20 18:49, Avi Kivity wrote: > New in this version: > - more mindless conversions; I believe there are no longer any destructive > operations in the tree (IO_MEM_UNASSIGNED) > - fix memory map generation bug (patch 13) > - proper 440FX PAM/SMRAM and PCI holes > This on top fixes standard VGA dirty logging: Cirrus is still broken (test case: grub), debugging ATM. Jan diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index e367052..8e8b24c 100644 --- a/hw/cirrus_vga.c +++ b/hw/cirrus_vga.c @@ -2944,8 +2944,6 @@ static int pci_cirrus_vga_initfn(PCIDevice *dev) memory_region_add_subregion(&s->pci_bar, 0x1000000, &s->cirrus_linear_bitblt_io); - vga_dirty_log_start(&s->vga); - /* setup memory space */ /* memory #0 LFB */ /* memory #1 memory-mapped I/O */ diff --git a/hw/vga.c b/hw/vga.c index 5a78b71..8acc545 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2195,6 +2195,7 @@ void vga_common_init(VGACommonState *s, int vga_ram_size) s->update_retrace_info = vga_precise_update_retrace_info; break; } + vga_dirty_log_start(s); } /* used by both ISA and PCI */