[Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12

Commit Message

Gerhard Wiesinger Oct. 28, 2017, 6:13 p.m. UTC

On 10.10.2017 16:16, Paolo Bonzini wrote:
> On 27/09/2017 21:31, Gerhard Wiesinger wrote:
>> On 15.09.2017 19:07, Paolo Bonzini wrote:
>>> On 15/09/2017 16:43, Gerhard Wiesinger wrote:
>>>> On 27.08.2017 20:55, Paolo Bonzini wrote:
>>>>> Il 27 ago 2017 4:48 PM, "Gerhard Wiesinger" <[e-mail]
>>>>> <mailto:[e-mail]>> ha scritto:
>>>>>
>>>>>       On 27.08.2017 14 <tel:27.08.2017%2014>:03, Paolo Bonzini wrote:
>>>>>
>>>>>
>>>>>           We will revert the patch, but 4.13.0 will not have the fix.
>>>>>           Expect it in later stable kernels (because vacations).
>>>>>
>>>>>
>>>>>       Thnx. Why will 4.13.0 NOT have the fix?
>>>>>
>>>>>
>>>>> Because maintainers are on vacation! :-)
>>>>>
>>>>>
>>>> Hello Paolo,
>>>>
>>>> Any update on this for 4.12 and 4.13 kernels?
>>> A late fix is better than a wrong fix.  Hope to get to it next week!
>> Hello Paolo,
>>
>> Any update? Thnx.
> Hey, I have a patch now.  Any volunteers for testing it?
>
> This is on top of 4.13.
>
> Paolo
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index c6ef2940119b..c29bf36485fd 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -200,6 +200,10 @@ struct loaded_vmcs {
>   	int cpu;
>   	bool launched;
>   	bool nmi_known_unmasked;
> +	/* Support for vnmi-less CPUs */
> +	int soft_vnmi_blocked;
> +	ktime_t entry_time;
> +	s64 vnmi_blocked_time;
>   	struct list_head loaded_vmcss_on_cpu_link;
>   };
>   

Hello Paolo,

The patch does not apply, 1st hunk FAILED.
cat arch/x86/kvm/vmx.c.rej
Tried it to apply against, doesn't look to fit:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/kvm/vmx.c?h=v4.13.10#n197
https://koji.fedoraproject.org/koji/buildinfo?buildID=991441

Will then recompile and test.

Thnx.

Ciao,
Gerhard

Comments

Gerhard Wiesinger Nov. 11, 2017, 7:27 a.m. UTC | #1

On 10.11.2017 17:29, Paolo Bonzini wrote:
> On 10/11/2017 16:33, Gerhard Wiesinger wrote:
>> Hello Paolo,
>>
>> Any update for a new patch?
> Yes,
>
> https://marc.info/?l=kvm&m=150997149623548&w=2
>
> Paolo

Works also for Fedora 26: 
https://koji.fedoraproject.org/koji/buildinfo?buildID=996781
kernel-4.13.12-200.fc26

Ready to release to 4.13.* upstream and 4.14 upstream kernels ...

https://bodhi.fedoraproject.org/updates/FEDORA-2017-abda708cee

Thnx.

Ciao,
Gerhard

Patch

--- arch/x86/kvm/vmx.c
+++ arch/x86/kvm/vmx.c
@@ -200,6 +200,10 @@  struct loaded_vmcs {
         int cpu;
         bool launched;
         bool nmi_known_unmasked;
+       /* Support for vnmi-less CPUs */
+       int soft_vnmi_blocked;
+       ktime_t entry_time;
+       s64 vnmi_blocked_time;
         struct list_head loaded_vmcss_on_cpu_link;
  };