diff mbox

Always return latest pmsts instead of the old one.

Message ID 706158FABBBA044BAD4FE898A02E4BC2223BCEA8@pdsmsx503.ccr.corp.intel.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Zhang, Xiantao Jan. 21, 2009, 3:51 a.m. UTC 
Any comments ?  If no, please help to check-in this patch. It blocks our work for a long time. Thanks!
Xiantao

-----Original Message-----
From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On Behalf Of Zhang, Xiantao
Sent: Monday, January 19, 2009 10:13 PM
To: Anthony Liguori
Cc: qemu-devel@nongnu.org; kvm@vger.kernel.org; Avi Kivity
Subject: RE: [PATCH] Always return latest pmsts instead of the old one.

Attached the new patch, please check.
Xiantao


Subject: Always return latest pmsts instead of the old one.

It may lead to the issue when booting windows guests with acpi=1
if return the old pmsts.

Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com>

Modified Paths:
--------------
    trunk/hw/acpi.c

Modified: trunk/hw/acpi.c



Anthony Liguori wrote:
> Zhang, Xiantao wrote:
>> For get_pmsts of acpi, it should always return latest value instead
>> of the old one. Xiantao 
>> 
>> 
>> From: Xiantao Zhang <xiantao.zhang@intel.com>
>> Date: Tue, 13 Jan 2009 17:42:16 +0800
>> Subject: [PATCH] Always return latest pmsts instead of the old one.
>> 
>> It may lead to the issue when booting windows guests with acpi=1
>> if return the old pmsts.
>> 
>> Signed-off-by: Xiantao Zhang <xiantao.zhang@intel.com> ---
>>  qemu/hw/acpi.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/qemu/hw/acpi.c b/qemu/hw/acpi.c
>> 
> 
> Please resubmit against QEMU, not kvm-userspace.
> 
> Regards,
> 
> Anthony Liguori
> 
>> index 0ff8851..8bde989 100644
>> --- a/qemu/hw/acpi.c
>> +++ b/qemu/hw/acpi.c
>> @@ -94,7 +94,7 @@ static int get_pmsts(PIIX4PMState *s)
>>      d = muldiv64(qemu_get_clock(vm_clock), PM_FREQ, ticks_per_sec);
>>      if (d >= s->tmr_overflow_time)
>>          s->pmsts |= TMROF_EN;
>> -    return pmsts;
>> +    return s->pmsts;
>>  }
>> 
>>  static void pm_update_sci(PIIX4PMState *s)

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

===================================================================

--- trunk/hw/acpi.c
+++ trunk/hw/acpi.c
@@ -92,7 +92,7 @@  static int get_pmsts(PIIX4PMState *s)
     d = muldiv64(qemu_get_clock(vm_clock), PM_FREQ, ticks_per_sec);
     if (d >= s->tmr_overflow_time)
         s->pmsts |= TMROF_EN;
-    return pmsts;
+    return s->pmsts;
 }
 
 static void pm_update_sci(PIIX4PMState *s)