From patchwork Tue Aug 8 17:08:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 13346613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EAABC04FDF for ; Tue, 8 Aug 2023 18:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235308AbjHHSIJ (ORCPT ); Tue, 8 Aug 2023 14:08:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235242AbjHHSHc (ORCPT ); Tue, 8 Aug 2023 14:07:32 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B370A79A for ; Tue, 8 Aug 2023 10:08:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Type:Date:Cc:To: From:Subject:Message-ID:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=4Cxaxfc6oSiSrUpgTyDTEScslyQPFH/56HB3b+fyjuw=; b=pJ2CoGrC6h9fRx8UQdijyV2Wwv rd6gAfW2UdgltpB5/RGoOjN8wzR8mTDUkD1jkVxE8omWYQsD9WrS9nYx2AVd5jUYj89h5TphO5mzv 7ZZP7TlnrI+RiB4v5apyb6bExS/z2oYP+F/vwwlPJjkNvUci78E3xkvzy74bdFzVi1qmrm57ikypy 2L8PFP78ygqRL4ySwGEoAQ/rU0qCxRpdiBp2JNryx92p0AkDlC3+fj+adadavkk0D9MUDpy8IBS1i zrtvXyHNQc08bEKFGbxLDGxn0Y4BSOF0NiHFs2ybcCzzNn5El40U9Ws9r9sXURNUQxD6y7dfJRFkB fs1Vr0mA==; Received: from [2001:8b0:10b:5:f83c:7084:b68b:2288] (helo=u3832b3a9db3152.ant.amazon.com) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qTQC9-0012ji-Cz; Tue, 08 Aug 2023 17:08:33 +0000 Message-ID: <782b63c1f9c41a6bfa771789cde4b45644b3a239.camel@infradead.org> Subject: [PATCH] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel From: David Woodhouse To: qemu-devel Cc: Paul Durrant , Paolo Bonzini , Marcelo Tosatti , kvm@vger.kernel.org Date: Tue, 08 Aug 2023 18:08:32 +0100 User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: David Woodhouse XENFEAT_supervisor_mode_kernel shouldn't be set for HVM guests. It confuses lscpu into thinking it's running in PVH mode. No non-cosmetic effects have been observed so far. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- Only really cosmetic. Don't feel strongly about whether it makes 8.1. target/i386/kvm/xen-emu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c index a8146115f0..b307c75713 100644 --- a/target/i386/kvm/xen-emu.c +++ b/target/i386/kvm/xen-emu.c @@ -267,7 +267,6 @@ static bool kvm_xen_hcall_xen_version(struct kvm_xen_exit *exit, X86CPU *cpu, fi.submap |= 1 << XENFEAT_writable_page_tables | 1 << XENFEAT_writable_descriptor_tables | 1 << XENFEAT_auto_translated_physmap | - 1 << XENFEAT_supervisor_mode_kernel | 1 << XENFEAT_hvm_callback_vector | 1 << XENFEAT_hvm_safe_pvclock | 1 << XENFEAT_hvm_pirqs;