From patchwork Sat Jun 18 07:07:42 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aneesh Kumar K.V" X-Patchwork-Id: 892782 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5I782MZ004901 for ; Sat, 18 Jun 2011 07:08:02 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751978Ab1FRHHz (ORCPT ); Sat, 18 Jun 2011 03:07:55 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:43383 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756Ab1FRHHy (ORCPT ); Sat, 18 Jun 2011 03:07:54 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p5I6nqpx010567 for ; Sat, 18 Jun 2011 00:49:52 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id p5I77ohH137316 for ; Sat, 18 Jun 2011 01:07:50 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p5I17nNn022149 for ; Fri, 17 Jun 2011 19:07:49 -0600 Received: from skywalker.linux.vnet.ibm.com ([9.79.197.104]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id p5I17i2I022022; Fri, 17 Jun 2011 19:07:46 -0600 From: "Aneesh Kumar K.V" To: Pekka Enberg , Sasha Levin Cc: kvm@vger.kernel.org Subject: Re: [PATCH 1/2] tools/kvm/9p: Always include system header before our headers In-Reply-To: <1308340059.28516.3.camel@jaguar> References: <1308334282-11865-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1308339906.8711.13.camel@lappy> <1308340059.28516.3.camel@jaguar> User-Agent: Notmuch/0.5-215-g5143e5e (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Sat, 18 Jun 2011 12:37:42 +0530 Message-ID: <87sjr71utd.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sat, 18 Jun 2011 07:08:02 +0000 (UTC) On Fri, 17 Jun 2011 22:47:39 +0300, Pekka Enberg wrote: > On Fri, 2011-06-17 at 15:45 -0400, Sasha Levin wrote: > > On Fri, 2011-06-17 at 23:41 +0530, Aneesh Kumar K.V wrote: > > > Otherwise many things can break, such as mapping of stat to stat64 > > > > We always include our headers before system headers to make sure we > > don't have any hidden prerequisites or dependencies within the headers. > > > > Why did you need to move system headers before our headers in this case? > > The stat64() breakage seems rather odd since we do this in the Makefile: > > DEFINES += -D_FILE_OFFSET_BITS=64 > DEFINES += -D_GNU_SOURCE > > Aneesh, what kind of build problems are you seeing? Ok the below change also fix the issue for me. So it could be some mapping in the kernel headers --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/tools/kvm/virtio/9p.c b/tools/kvm/virtio/9p.c index 38a997d..730f4a1 100644 --- a/tools/kvm/virtio/9p.c +++ b/tools/kvm/virtio/9p.c @@ -9,16 +9,16 @@ #include "kvm/threadpool.h" #include "kvm/irq.h" -#include -#include -#include - #include #include #include #include #include +#include +#include +#include + #define NUM_VIRT_QUEUES 1 #define VIRTIO_P9_QUEUE_SIZE 128 #define VIRTIO_P9_TAG "kvm_9p"