From patchwork Wed Dec 18 22:05:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 3373681 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7222C9F344 for ; Wed, 18 Dec 2013 22:05:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A7027205E9 for ; Wed, 18 Dec 2013 22:05:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC43D205E4 for ; Wed, 18 Dec 2013 22:05:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751842Ab3LRWFU (ORCPT ); Wed, 18 Dec 2013 17:05:20 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36813 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752701Ab3LRWFR convert rfc822-to-8bit (ORCPT ); Wed, 18 Dec 2013 17:05:17 -0500 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CBCD3ABC7; Wed, 18 Dec 2013 22:05:15 +0000 (UTC) Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: [v5][PATCH] KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state From: Alexander Graf In-Reply-To: <5297F597.6080301@windriver.com> Date: Wed, 18 Dec 2013 23:05:37 +0100 Cc: Scott Wood , "kvm@vger.kernel.org mailing list" , kvm-ppc@vger.kernel.org Message-Id: References: <1382491608-4535-1-git-send-email-tiejun.chen@windriver.com> <5289D10D.5020506@windriver.com> <925AA130-F432-4367-BB55-AF833861AB60@suse.de> <5297F597.6080301@windriver.com> To: =?windows-1252?Q?=22=93tiejun=2Echen=94=22?= X-Mailer: Apple Mail (2.1827) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 29.11.2013, at 03:01, “tiejun.chen” wrote: > Alex, > > I suppose Scott already elaborate anything you want to know. Thanks, applied with this minor patch on top: I've also taken the liberty of making the patch description be more verbose: KVM: PPC: Book3E HV: call RECONCILE_IRQ_STATE to sync the software state Rather than calling hard_irq_disable() when we're back in C code we can just call RECONCILE_IRQ_STATE to soft disable IRQs while we're already in hard disabled state. This should be functionally equivalent to the code before, but cleaner and faster. Signed-off-by: Tiejun Chen [agraf: fix comment, commit message] Signed-off-by: Alexander Graf Thanks, applied to kvm-ppc-queue. Alex --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/powerpc/kvm/bookehv_interrupts.S b/arch/powerpc/kvm/bookehv_interrupts.S index 191c32b..be3de1d 100644 --- a/arch/powerpc/kvm/bookehv_interrupts.S +++ b/arch/powerpc/kvm/bookehv_interrupts.S @@ -470,7 +470,7 @@ _GLOBAL(kvmppc_resume_host) #ifdef CONFIG_64BIT /* * We enter with interrupts disabled in hardware, but - * we need to call RECONCILE_IRQ_STATE anyway to ensure + * we need to call RECONCILE_IRQ_STATE to ensure * that the software state is kept in sync. */ RECONCILE_IRQ_STATE(r3,r5)