From patchwork Mon Feb 2 02:34:43 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "SourceForge.net" X-Patchwork-Id: 5033 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n122Z7A2016827 for ; Mon, 2 Feb 2009 02:35:07 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753361AbZBBCfF (ORCPT ); Sun, 1 Feb 2009 21:35:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753410AbZBBCfF (ORCPT ); Sun, 1 Feb 2009 21:35:05 -0500 Received: from ch3.sourceforge.net ([216.34.181.60]:48137 "EHLO 49zxpd1.ch3.sourceforge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753361AbZBBCfD (ORCPT ); Sun, 1 Feb 2009 21:35:03 -0500 Received: from localhost ([127.0.0.1] helo=49zxpd1.ch3.sourceforge.com) by 49zxpd1.ch3.sourceforge.com with smtp (Exim 4.69) (envelope-from ) id 1LToe3-0000QM-UX; Mon, 02 Feb 2009 02:34:44 +0000 Received: by 49zxpd1.ch3.sourceforge.com (sSMTP sendmail emulation); Mon, 2 Feb 2009 02:34:43 +0000 Date: Mon, 2 Feb 2009 02:34:43 +0000 To: noreply@sourceforge.net From: "SourceForge.net" Subject: [ kvm-Bugs-2168011 ] kvm_host.h:128: error: field 'mmu_notifier' has incomplete Mime-Version: 1.0 X-SourceForge-Tracker-unixname: kvm X-SourceForge-Tracker-trackerid: 893831 X-SourceForge-Tracker-itemid: 2168011 X-SourceForge-Tracker-itemstatus: Closed X-SourceForge-Tracker-itemassignee: nobody X-SourceForge-Tracker-itemupdate-reason: Comment added X-SourceForge-Tracker-itemupdate-username: sf-robot Message-Id: Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Bugs item #2168011, was opened at 2008-10-15 09:53 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2168011&group_id=180599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Stephane Bakhos (nuitari3) Assigned to: Nobody/Anonymous (nobody) Summary: kvm_host.h:128: error: field 'mmu_notifier' has incomplete Initial Comment: When compiling kvm-77/76 on a 2.6.27 kernel with AMD IOMMU activated I get: kvm_host.h:128: error: field 'mmu_notifier' has incomplete type ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2009-02-02 02:34 Message: This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Wolfram Gloger (wg1) Date: 2008-12-25 10:21 Message: It would only print a warning for those old kernels, not "break" them. ---------------------------------------------------------------------- Comment By: Avi Kivity (avik) Date: 2008-12-24 16:27 Message: Well, very old kernels don't have kvm support at all, and this would break them. ---------------------------------------------------------------------- Comment By: Wolfram Gloger (wg1) Date: 2008-12-24 15:53 Message: Oops, you are correct of course. CONFIG_KVM set and all is well. May I suggest the following patch so this doesn't bite people so easily. --arch="$arch" --processor="$processor" \ ---------------------------------------------------------------------- Comment By: Avi Kivity (avik) Date: 2008-12-24 13:49 Message: You should enable the host kernel's kvm modules even if you don't plan to use them, so they will select functionality like mmu notifiers. ---------------------------------------------------------------------- Comment By: Wolfram Gloger (wg1) Date: 2008-12-15 18:11 Message: Sorry, cannot seem to attach a file (I looked hard!), so here the patch inline (applies to kvm-81, too): --- kernel/include/linux/kvm_host.h.orig 2008-11-12 13:23:58.000000000 +0100 +++ kernel/include/linux/kvm_host.h 2008-11-15 21:08:02.000000000 +0100 @@ -46,6 +46,7 @@ * the COPYING file in the top-level directory. */ +#include #include #include #include --- kernel/include/linux/mmu_notifier.h.orig 2008-12-15 18:31:52.000000000 +0100 +++ kernel/include/linux/mmu_notifier.h 2008-11-15 21:19:08.000000000 +0100 @@ -0,0 +1,6 @@ +#ifndef _LINUX_MMU_NOTIFIER_H +#define _LINUX_MMU_NOTIFIER_H + +struct mmu_notifier {}; + +#endif ---------------------------------------------------------------------- Comment By: Wolfram Gloger (wg1) Date: 2008-12-15 18:00 Message: I'm seeing this too, with kvm-79 and now kvm-81 on Linux-2.6.27.7 and Linux-2.6.27.9. I'm surprised that such a FTBS is not more prevalent.. For now, I have helped myself with the attached patch. ---------------------------------------------------------------------- Comment By: Stephane Bakhos (nuitari3) Date: 2008-10-15 14:18 Message: It looks like I was wrong in saying that AMD IOMMU was the cause. When I complied again I used make -j5 and it looks like it just skipped the kernel modules. ---------------------------------------------------------------------- Comment By: Stephane Bakhos (nuitari3) Date: 2008-10-15 10:11 Message: It looks like I was wrong in saying that AMD IOMMU was the cause. When I complied again I used make -j5 and it looks like it just skipped the kernel modules. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2168011&group_id=180599 --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- configure.orig 2008-12-14 14:16:27.000000000 +0100 +++ configure 2008-12-24 16:46:03.000000000 +0100 @@ -134,6 +134,19 @@ fi fi +if [ -e "$kerneldir/.config" ]; then + if egrep -q "^CONFIG_KVM=(y|m)" "$kerneldir/.config"; then + : + else + echo "Warning: kernel not configured for KVM" + echo "kvm kernel modules may not build correctly" + fi +else + echo "Error: kernel .config not found" + echo "Please make sure your kernel is configured" + exit 1 +fi + #configure user dir (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir" \