From patchwork Tue Jun 9 16:57:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "SourceForge.net" X-Patchwork-Id: 29053 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n59Gv5I0024898 for ; Tue, 9 Jun 2009 16:57:05 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754219AbZFIQ5A (ORCPT ); Tue, 9 Jun 2009 12:57:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753587AbZFIQ5A (ORCPT ); Tue, 9 Jun 2009 12:57:00 -0400 Received: from ch3.sourceforge.net ([216.34.181.60]:31605 "EHLO ch3.sourceforge.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753483AbZFIQ47 (ORCPT ); Tue, 9 Jun 2009 12:56:59 -0400 Received: from www by 665xhf1.ch3.sourceforge.com with local (Exim 4.69) (envelope-from ) id 1ME4dB-0007u5-NE; Tue, 09 Jun 2009 16:57:01 +0000 To: noreply@sourceforge.net From: "SourceForge.net" Subject: [ kvm-Bugs-2803653 ] kvm-86: winxp guest caps-lock broken Mime-Version: 1.0 X-SourceForge-Tracker-unixname: kvm X-SourceForge-Tracker-trackerid: 893831 X-SourceForge-Tracker-itemid: 2803653 X-SourceForge-Tracker-itemstatus: Open X-SourceForge-Tracker-itemassignee: nobody X-SourceForge-Tracker-itemupdate-reason: Tracker Item Submitted X-SourceForge-Tracker-itemupdate-username: vinyvat Message-Id: Date: Tue, 09 Jun 2009 16:57:01 +0000 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Bugs item #2803653, was opened at 2009-06-09 09:57 Message generated for change (Tracker Item Submitted) made by vinyvat You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2803653&group_id=180599 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Geoffrey Brimhall (vinyvat) Assigned to: Nobody/Anonymous (nobody) Summary: kvm-86: winxp guest caps-lock broken Initial Comment: * cpu model: Core i7 920 * kvm version: kvm 86 * host kernel version: 2.6.29.4 debian lenny * host kernel arch: x86_64 * guest: winxp 32bit sp3 * qemu command line: qemu-system-x86_64 -boot c -hda ./winxp.qcow2 -cdrom winxp-sp3.iso -smp 2 -m 1024 -vga std -net nic,model=virtio,vlan=0,macaddr=00:15:60:51:09:BD -net tap,vlan=0,ifname=tap0,script=/etc/kvm/kvm-ifup -soundhw es1370 -localtime -k en-us -name XXXX -usb with both kvm-86 downloaded and built, and debian's experimental kvm-85 package, caps-lock key with winxp guest is broken. Debian has a bug ( # 441068 )with a suggested patch fix. When I manually apply just the following snippet from the patch to either debian's kvm-86 or the downloaded kvm-86 source tarball and rebuild the binary, it fixes the bug: RCS file: /sources/qemu/qemu/sdl.c,v retrieving revision 1.42 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2803653&group_id=180599 --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -u -r1.42 sdl.c --- sdl.c 21 Jun 2007 21:08:02 -0000 1.42 +++ sdl.c 28 Aug 2007 04:09:19 -0000 @@ -201,9 +201,9 @@ break; case 0x45: /* num lock */ case 0x3a: /* caps lock */ - /* SDL does not send the key up event, so we generate it */ - kbd_put_keycode(keycode); - kbd_put_keycode(keycode | 0x80); + if (ev->type == SDL_KEYUP) + kbd_put_keycode(keycode | 0x80); + else kbd_put_keycode(keycode); return; }