[kvm-Bugs-2835276] segfault using -cpu pentium3 on coreduo

Commit Message

SourceForge.net Aug. 11, 2009, 1:39 a.m. UTC

Bugs item #2835276, was opened at 2009-08-10 21:38
Message generated for change (Tracker Item Submitted) made by agriffis
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2835276&group_id=180599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: qemu
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Aron Griffis (agriffis)
Assigned to: Nobody/Anonymous (nobody)
Summary: segfault using -cpu pentium3 on coreduo

Initial Comment:
qemu-0.11.0-rc1 and qemu-kvm-HEAD segfault with -cpu pentium3 on ProLiant DL380
G5 (dual-socket dual-core Intel Xeon 5160).  This is a regression from
qemu-0.10.6 which does not have the problem.

Using -cpu coreduo avoids the segfault.  -cpu athlon works too.

I bisected to find that the problem is introduced by
0ed8cfc05bb012e52b92771bb13bef0e2e80c828 and can be worked around by the
following patch to HEAD which effectively reverts that commit:




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=2835276&group_id=180599
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1096,11 +1096,11 @@  CPUState *pc_new_cpu(const char *cpu_model)
         }
         if ((env->cpuid_features & CPUID_APIC) || smp_cpus > 1) {
             env->cpuid_apic_id = env->cpu_index;
-            /* APIC reset callback resets cpu */
-            apic_init(env);
         } else {
             qemu_register_reset((QEMUResetHandler*)cpu_reset, env);
         }
+            /* APIC reset callback resets cpu */
+            apic_init(env);
 
     /* kvm needs this to run after the apic is initialized. Otherwise,
      * it can access invalid state and crash.