From patchwork Sun May 24 15:46:41 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Goldish X-Patchwork-Id: 25596 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4OFiXVu012408 for ; Sun, 24 May 2009 15:44:34 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754835AbZEXPob (ORCPT ); Sun, 24 May 2009 11:44:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754814AbZEXPoa (ORCPT ); Sun, 24 May 2009 11:44:30 -0400 Received: from mx2.redhat.com ([66.187.237.31]:49714 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754573AbZEXPo3 (ORCPT ); Sun, 24 May 2009 11:44:29 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4OFiVPP029844 for ; Sun, 24 May 2009 11:44:31 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n4OFiUTS019932; Sun, 24 May 2009 11:44:30 -0400 Received: from localhost.localdomain (dhcp-1-188.tlv.redhat.com [10.35.1.188]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n4OFiMTx009023; Sun, 24 May 2009 11:44:29 -0400 From: Michael Goldish To: kvm@vger.kernel.org Cc: Michael Goldish Subject: [KVM-AUTOTEST PATCH] VM.create(): always destroy() the VM before attempting to start it Date: Sun, 24 May 2009 18:46:41 +0300 Message-Id: In-Reply-To: References: <8e37a36c044c20259dcd8a34d72a651e85b37d5f.1243179847.git.mgoldish@redhat.com> <838bcae1b49be011e2cde1294a391a296059464a.1243179847.git.mgoldish@redhat.com> <6a70cb56a775fdb688da0231073abb0ce4baa7b1.1243179847.git.mgoldish@redhat.com> In-Reply-To: <8e37a36c044c20259dcd8a34d72a651e85b37d5f.1243179847.git.mgoldish@redhat.com> References: <8e37a36c044c20259dcd8a34d72a651e85b37d5f.1243179847.git.mgoldish@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Also, don't do it in kvm_preprocessing.py since it's now done in kvm_vm.py. Signed-off-by: Michael Goldish --- client/tests/kvm_runtest_2/kvm_preprocessing.py | 1 - client/tests/kvm_runtest_2/kvm_vm.py | 2 ++ 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/client/tests/kvm_runtest_2/kvm_preprocessing.py b/client/tests/kvm_runtest_2/kvm_preprocessing.py index bcabf5a..9ccaf78 100644 --- a/client/tests/kvm_runtest_2/kvm_preprocessing.py +++ b/client/tests/kvm_runtest_2/kvm_preprocessing.py @@ -84,7 +84,6 @@ def preprocess_vm(test, params, env, name): start_vm = True if start_vm: - vm.destroy() if not vm.create(name, params, qemu_path, image_dir, iso_dir, for_migration): message = "Could not start VM" kvm_log.error(message) diff --git a/client/tests/kvm_runtest_2/kvm_vm.py b/client/tests/kvm_runtest_2/kvm_vm.py index df99859..a1462c6 100644 --- a/client/tests/kvm_runtest_2/kvm_vm.py +++ b/client/tests/kvm_runtest_2/kvm_vm.py @@ -238,6 +238,8 @@ class VM: stored in the class attributes is used, and if it is supplied, it is stored for later use. """ + self.destroy() + if name != None: self.name = name if params != None: