| Message ID | e1f311a32a1721cb138982d475515e24f18e4edb.1730118186.git.kai.huang@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | TDX host: metadata reading tweaks, bug fix and info dump | expand |
On 28.10.24 г. 14:41 ч., Kai Huang wrote: > Currently, the 'struct tdmr_sys_info_tdmr' which includes TDMR related > fields defines the PAMT entry sizes for TDX supported page sizes (4KB, > 2MB and 1GB) as an array: > > struct tdx_sys_info_tdmr { > ... > u16 pamt_entry_sizes[TDX_PS_NR]; > }; > > PAMT entry sizes are needed when allocating PAMTs for each TDMR. Using > the array to contain PAMT entry sizes reduces the number of arguments > that need to be passed when calling tdmr_set_up_pamt(). It also makes > the code pattern like below clearer: > > for (pgsz = TDX_PS_4K; pgsz < TDX_PS_NR; pgsz++) { > pamt_size[pgsz] = tdmr_get_pamt_sz(tdmr, pgsz, > pamt_entry_size[pgsz]); > tdmr_pamt_size += pamt_size[pgsz]; > } > > However, the auto-generated metadata reading code generates a structure > member for each field. The 'global_metadata.json' has a dedicated field > for each PAMT entry size, and the new 'struct tdx_sys_info_tdmr' looks > like: > > struct tdx_sys_info_tdmr { > ... > u16 pamt_4k_entry_size; > u16 pamt_2m_entry_size; > u16 pamt_1g_entry_size; > }; > > To prepare to use the auto-generated code, make the existing 'struct > tdx_sys_info_tdmr' look like the generated one. But when passing to > tdmrs_set_up_pamt_all(), build a local array of PAMT entry sizes from > the structure so the code to allocate PAMTs can stay the same. > > Signed-off-by: Kai Huang <kai.huang@intel.com> Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>
Kai Huang wrote: > Currently, the 'struct tdmr_sys_info_tdmr' which includes TDMR related > fields defines the PAMT entry sizes for TDX supported page sizes (4KB, > 2MB and 1GB) as an array: > > struct tdx_sys_info_tdmr { > ... > u16 pamt_entry_sizes[TDX_PS_NR]; > }; > > PAMT entry sizes are needed when allocating PAMTs for each TDMR. Using > the array to contain PAMT entry sizes reduces the number of arguments > that need to be passed when calling tdmr_set_up_pamt(). It also makes > the code pattern like below clearer: > > for (pgsz = TDX_PS_4K; pgsz < TDX_PS_NR; pgsz++) { > pamt_size[pgsz] = tdmr_get_pamt_sz(tdmr, pgsz, > pamt_entry_size[pgsz]); > tdmr_pamt_size += pamt_size[pgsz]; > } > > However, the auto-generated metadata reading code generates a structure > member for each field. The 'global_metadata.json' has a dedicated field > for each PAMT entry size, and the new 'struct tdx_sys_info_tdmr' looks > like: > > struct tdx_sys_info_tdmr { > ... > u16 pamt_4k_entry_size; > u16 pamt_2m_entry_size; > u16 pamt_1g_entry_size; > }; > > To prepare to use the auto-generated code, make the existing 'struct > tdx_sys_info_tdmr' look like the generated one. But when passing to > tdmrs_set_up_pamt_all(), build a local array of PAMT entry sizes from > the structure so the code to allocate PAMTs can stay the same. > > Signed-off-by: Kai Huang <kai.huang@intel.com> Makes sense to align with the autogenerated code to reduce maintenance/review fatigue going forward. Reviewed-by: Dan Williams <dan.j.williams@intel.com>
diff --git a/arch/x86/virt/vmx/tdx/tdx.c b/arch/x86/virt/vmx/tdx/tdx.c index 7a2f979092e7..28537a6c47fc 100644 --- a/arch/x86/virt/vmx/tdx/tdx.c +++ b/arch/x86/virt/vmx/tdx/tdx.c @@ -304,9 +304,9 @@ struct field_mapping { static const struct field_mapping fields[] = { TD_SYSINFO_MAP(MAX_TDMRS, max_tdmrs), TD_SYSINFO_MAP(MAX_RESERVED_PER_TDMR, max_reserved_per_tdmr), - TD_SYSINFO_MAP(PAMT_4K_ENTRY_SIZE, pamt_entry_size[TDX_PS_4K]), - TD_SYSINFO_MAP(PAMT_2M_ENTRY_SIZE, pamt_entry_size[TDX_PS_2M]), - TD_SYSINFO_MAP(PAMT_1G_ENTRY_SIZE, pamt_entry_size[TDX_PS_1G]), + TD_SYSINFO_MAP(PAMT_4K_ENTRY_SIZE, pamt_4k_entry_size), + TD_SYSINFO_MAP(PAMT_2M_ENTRY_SIZE, pamt_2m_entry_size), + TD_SYSINFO_MAP(PAMT_1G_ENTRY_SIZE, pamt_1g_entry_size), }; static int get_tdx_sys_info_tdmr(struct tdx_sys_info_tdmr *sysinfo_tdmr) @@ -932,14 +932,18 @@ static int construct_tdmrs(struct list_head *tmb_list, struct tdmr_info_list *tdmr_list, struct tdx_sys_info_tdmr *sysinfo_tdmr) { + u16 pamt_entry_size[TDX_PS_NR] = { + sysinfo_tdmr->pamt_4k_entry_size, + sysinfo_tdmr->pamt_2m_entry_size, + sysinfo_tdmr->pamt_1g_entry_size, + }; int ret; ret = fill_out_tdmrs(tmb_list, tdmr_list); if (ret) return ret; - ret = tdmrs_set_up_pamt_all(tdmr_list, tmb_list, - sysinfo_tdmr->pamt_entry_size); + ret = tdmrs_set_up_pamt_all(tdmr_list, tmb_list, pamt_entry_size); if (ret) return ret; diff --git a/arch/x86/virt/vmx/tdx/tdx.h b/arch/x86/virt/vmx/tdx/tdx.h index 2600ec3752f5..ec879d54eb5c 100644 --- a/arch/x86/virt/vmx/tdx/tdx.h +++ b/arch/x86/virt/vmx/tdx/tdx.h @@ -84,7 +84,9 @@ struct tdmr_info { struct tdx_sys_info_tdmr { u16 max_tdmrs; u16 max_reserved_per_tdmr; - u16 pamt_entry_size[TDX_PS_NR]; + u16 pamt_4k_entry_size; + u16 pamt_2m_entry_size; + u16 pamt_1g_entry_size; }; /* Kernel used global metadata fields */
Currently, the 'struct tdmr_sys_info_tdmr' which includes TDMR related fields defines the PAMT entry sizes for TDX supported page sizes (4KB, 2MB and 1GB) as an array: struct tdx_sys_info_tdmr { ... u16 pamt_entry_sizes[TDX_PS_NR]; }; PAMT entry sizes are needed when allocating PAMTs for each TDMR. Using the array to contain PAMT entry sizes reduces the number of arguments that need to be passed when calling tdmr_set_up_pamt(). It also makes the code pattern like below clearer: for (pgsz = TDX_PS_4K; pgsz < TDX_PS_NR; pgsz++) { pamt_size[pgsz] = tdmr_get_pamt_sz(tdmr, pgsz, pamt_entry_size[pgsz]); tdmr_pamt_size += pamt_size[pgsz]; } However, the auto-generated metadata reading code generates a structure member for each field. The 'global_metadata.json' has a dedicated field for each PAMT entry size, and the new 'struct tdx_sys_info_tdmr' looks like: struct tdx_sys_info_tdmr { ... u16 pamt_4k_entry_size; u16 pamt_2m_entry_size; u16 pamt_1g_entry_size; }; To prepare to use the auto-generated code, make the existing 'struct tdx_sys_info_tdmr' look like the generated one. But when passing to tdmrs_set_up_pamt_all(), build a local array of PAMT entry sizes from the structure so the code to allocate PAMTs can stay the same. Signed-off-by: Kai Huang <kai.huang@intel.com> --- arch/x86/virt/vmx/tdx/tdx.c | 14 +++++++++----- arch/x86/virt/vmx/tdx/tdx.h | 4 +++- 2 files changed, 12 insertions(+), 6 deletions(-)