| Message ID | 20200909085426.19862-1-brgl@bgdev.pl (mailing list archive) |
|---|---|
| Headers | show |
| Series | gpiolib: generalize GPIO line names property | expand |
On Wed, Sep 09, 2020 at 10:54:23AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I initially sent this as part of the gpio-mockup overhaul but since > these patches are indepentent and the work on gpio-mockup may become > more complicated - I'm sending these separately. > > The only change is adding additional property helpers to count strings > in array. > > v1 -> v2: > - actually remove the previous devprop source file in patch 3 > - rename the string counting functions to something more explicit > > Bartosz Golaszewski (3): > device: property: add helpers to count items in string arrays > gpiolib: generalize devprop_gpiochip_set_names() for device properties > gpiolib: unexport devprop_gpiochip_set_names() The series looks good to me, Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On Wed, Sep 09, 2020 at 10:54:23AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > I initially sent this as part of the gpio-mockup overhaul but since > these patches are indepentent and the work on gpio-mockup may become > more complicated - I'm sending these separately. > > The only change is adding additional property helpers to count strings > in array. Seems it lost my tag for patch 1/3, but in any case now I'm good with it Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > v1 -> v2: > - actually remove the previous devprop source file in patch 3 > - rename the string counting functions to something more explicit > > Bartosz Golaszewski (3): > device: property: add helpers to count items in string arrays > gpiolib: generalize devprop_gpiochip_set_names() for device properties > gpiolib: unexport devprop_gpiochip_set_names() > > drivers/gpio/Makefile | 1 - > drivers/gpio/gpiolib-acpi.c | 3 -- > drivers/gpio/gpiolib-devprop.c | 63 ---------------------------------- > drivers/gpio/gpiolib-of.c | 5 --- > drivers/gpio/gpiolib.c | 55 ++++++++++++++++++++++++++--- > include/linux/gpio/driver.h | 3 -- > include/linux/property.h | 13 +++++++ > 7 files changed, 64 insertions(+), 79 deletions(-) > delete mode 100644 drivers/gpio/gpiolib-devprop.c > > -- > 2.26.1 >
On Wed, Sep 9, 2020 at 12:34 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Wed, Sep 09, 2020 at 10:54:23AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > I initially sent this as part of the gpio-mockup overhaul but since > > these patches are indepentent and the work on gpio-mockup may become > > more complicated - I'm sending these separately. > > > > The only change is adding additional property helpers to count strings > > in array. > > Seems it lost my tag for patch 1/3, but in any case now I'm good with it > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > I removed your tag from patch 1 because I changed the name of the helpers. Bartosz
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> I initially sent this as part of the gpio-mockup overhaul but since these patches are indepentent and the work on gpio-mockup may become more complicated - I'm sending these separately. The only change is adding additional property helpers to count strings in array. v1 -> v2: - actually remove the previous devprop source file in patch 3 - rename the string counting functions to something more explicit Bartosz Golaszewski (3): device: property: add helpers to count items in string arrays gpiolib: generalize devprop_gpiochip_set_names() for device properties gpiolib: unexport devprop_gpiochip_set_names() drivers/gpio/Makefile | 1 - drivers/gpio/gpiolib-acpi.c | 3 -- drivers/gpio/gpiolib-devprop.c | 63 ---------------------------------- drivers/gpio/gpiolib-of.c | 5 --- drivers/gpio/gpiolib.c | 55 ++++++++++++++++++++++++++--- include/linux/gpio/driver.h | 3 -- include/linux/property.h | 13 +++++++ 7 files changed, 64 insertions(+), 79 deletions(-) delete mode 100644 drivers/gpio/gpiolib-devprop.c