From patchwork Tue Feb 7 01:41:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saravana Kannan X-Patchwork-Id: 13130852 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A101EC05027 for ; Tue, 7 Feb 2023 01:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229906AbjBGBmO (ORCPT ); Mon, 6 Feb 2023 20:42:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbjBGBmN (ORCPT ); Mon, 6 Feb 2023 20:42:13 -0500 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 541DD10A81 for ; Mon, 6 Feb 2023 17:42:11 -0800 (PST) Received: by mail-pf1-x44a.google.com with SMTP id z2-20020a626502000000b0059085684b50so7359583pfb.16 for ; Mon, 06 Feb 2023 17:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=5Lzwmfi68lbdrUMbtc6adBz2FR099zCl1IbhLNZPH1k=; b=AiCfxSp7rvYdlgl0hl4blBlUcDhKmP2ipQWAy9D+v4OffGK0tOAZAVe6vj1m5Qqb1N EjVKK0seT/KHqRY31wLEaQnNOfPf2YnCeLt3UYVQcttmFjIdZOKxHDXNZbOFbd6VC/Qs YNWCMN8S77uoudgWgBuiUlIQHmrkrOS93xAFfs/JCgWixMPTZKa7k1u41pU7om9nNL9z xPGzdgebPBxzGe2RJ+Q4NwYLmakenKFtNcj/xZeImi7KWdRpF2+9iQmiJWyzIbJMCV4D E4rbGyjlteWJX7skmBf/WRPXHpbjKXCwbF2v1IQwRsB/gvBU/gqaLXL7ZiasmH3GDDgW 1JOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5Lzwmfi68lbdrUMbtc6adBz2FR099zCl1IbhLNZPH1k=; b=vrw/pPwn/tULj+pWSxMVgI8QwHpf+8yp0eDk5YL0/cfSVckU01sZuzi0SQiYeS9dpI ZWYnB08uhGZaJ0xHljuNY3TPBIIdqpgE7Uhgs+g6suDJwL58Cwd5QH30vzQtt9rYH9yZ ZqJYcrQn43PQ6edSQ6N7sj9Q66lDqh8oxl4oCZ25fQk07G2iXk26f45rt5HXbqWaYrSu TsBEhkAcrPg6tHHHXBhVOqkHfP3VRh0kaKHIVb26IAsXGISLTY38MdLkGRUL9CxZ3tF3 0HjXTVW/ESNxUaoh4jv6K4tRDrTxEJdSC9XXBx71vcOl6Z4DPhu8F9HImRCabb9bP/+7 md4Q== X-Gm-Message-State: AO0yUKWS1IJwttLoJe2Gc7U++tkU+I9O6VmUEoVD6PUuoCJueLrewhLF fblV6AqADt2UcZgzWN3Yzl0muRlp9JcMIqA= X-Google-Smtp-Source: AK7set+EAwfeBS4EZdincaahfqhxKjG9TUS0REB1NbACugqOxKLsnOyVz3Xl+5qV5fiy7WsvyHpw/x+7WRzIigU= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:ae1:aba6:f21c:4a94]) (user=saravanak job=sendgmr) by 2002:a17:90a:5a05:b0:22c:46e:6510 with SMTP id b5-20020a17090a5a0500b0022c046e6510mr459339pjd.9.1675734130693; Mon, 06 Feb 2023 17:42:10 -0800 (PST) Date: Mon, 6 Feb 2023 17:41:52 -0800 Message-Id: <20230207014207.1678715-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.39.1.519.gcb327c4b5f-goog Subject: [PATCH v3 00/12] fw_devlink improvements From: Saravana Kannan To: Greg Kroah-Hartman , "Rafael J. Wysocki" , Sudeep Holla , Cristian Marussi , Linus Walleij , Bartosz Golaszewski , Thomas Gleixner , Marc Zyngier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Frank Rowand , Geert Uytterhoeven , Magnus Damm , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , Saravana Kannan , " =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= " Cc: Abel Vesa , Alexander Stein , Tony Lindgren , Geert Uytterhoeven , John Stultz , Doug Anderson , Guenter Roeck , Dmitry Baryshkov , Maxim Kiselev , Maxim Kochetkov , Luca Weiss , Colin Foster , Martin Kepplinger , Jean-Philippe Brucker , Vladimir Oltean , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-acpi@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Naresh, Tony, Abel, Geert, Dmitry, Maxim(s), Miquel, Luca, Doug, Martin, Jean-Philippe, Can I get your Tested-by's for this v3 series please? Vladimir, Ccing you because DSA's and fw_devlink have known/existing problems (still in my TODOs to fix). But I want to make sure this series doesn't cause additional problems for DSA. All, This patch series improves fw_devlink in the following ways: 1. It no longer cares about a fwnode having a "compatible" property. It figures this out more dynamically. The only expectation is that fwnodes that are converted to devices actually get probed by a driver for the dependencies to be enforced correctly. 2. Finer grained dependency tracking. fw_devlink will now create device links from the consumer to the actual resource's device (if it has one, Eg: gpio_device) instead of the parent supplier device. This improves things like async suspend/resume ordering, potentially remove the need for frameworks to create device links, more parallelized async probing, and better sync_state() tracking. 3. Handle hardware/software quirks where a child firmware node gets populated as a device before its parent firmware node AND actually supplies a non-optional resource to the parent firmware node's device. 4. Way more robust at cycle handling (see patch for the insane cases). 5. Stops depending on OF_POPULATED to figure out some corner cases. 6. Simplifies the work that needs to be done by the firmware specific code. The v3 series has gone through my usual testing on my end and looks good to me. Thanks, Saravana [1] - https://lore.kernel.org/lkml/20220810060040.321697-1-saravanak@google.com/ [2] - https://lore.kernel.org/lkml/CAGETcx-JUV1nj8wBJrTPfyvM7=Mre5j_vkVmZojeiumUGG6QZQ@mail.gmail.com/ v1 -> v2: - Fixed Patch 1 to handle a corner case discussed in [2]. - New patch 10 to handle "fsl,imx8mq-gpc" being initialized by 2 drivers. - New patch 11 to add fw_devlink support for SCMI devices. v2 -> v3: - Addressed most of Andy's comments in v2 - Added Colin and Sudeep's Tested-by for the series (except the imx and renesas patches) - Added Sudeep's Acked-by for the scmi patch. - Added Geert's Reviewed-by for the renesas patch. - Fixed gpiolib crash reported by Naresh. - Patch 6: Fix __fwnode_links_move_consumers() to preserve fwnode link flags. - New Patch 12 to fix nvmem-cells issue reported by Maxim(s)/Miquel. - Deleted some stale function doc in Patch 8 Cc: Abel Vesa Cc: Alexander Stein Cc: Tony Lindgren Cc: Sudeep Holla Cc: Geert Uytterhoeven Cc: John Stultz Cc: Doug Anderson Cc: Guenter Roeck Cc: Dmitry Baryshkov Cc: Maxim Kiselev Cc: Maxim Kochetkov Cc: Miquel Raynal Cc: Luca Weiss Cc: Colin Foster Cc: Martin Kepplinger Cc: Jean-Philippe Brucker Cc: Vladimir Oltean Saravana Kannan (12): driver core: fw_devlink: Don't purge child fwnode's consumer links driver core: fw_devlink: Improve check for fwnode with no device/driver soc: renesas: Move away from using OF_POPULATED for fw_devlink gpiolib: Clear the gpio_device's fwnode initialized flag before adding driver core: fw_devlink: Add DL_FLAG_CYCLE support to device links driver core: fw_devlink: Allow marking a fwnode link as being part of a cycle driver core: fw_devlink: Consolidate device link flag computation driver core: fw_devlink: Make cycle detection more robust of: property: Simplify of_link_to_phandle() irqchip/irq-imx-gpcv2: Mark fwnode device as not initialized firmware: arm_scmi: Set fwnode for the scmi_device mtd: mtdpart: Don't create platform device that'll never probe drivers/base/core.c | 449 +++++++++++++++++++++----------- drivers/firmware/arm_scmi/bus.c | 3 +- drivers/gpio/gpiolib.c | 7 + drivers/irqchip/irq-imx-gpcv2.c | 1 + drivers/mtd/mtdpart.c | 10 + drivers/of/property.c | 84 +----- drivers/soc/imx/gpcv2.c | 2 +- drivers/soc/renesas/rcar-sysc.c | 2 +- include/linux/device.h | 1 + include/linux/fwnode.h | 12 +- 10 files changed, 344 insertions(+), 227 deletions(-) Tested-by: Luca Weiss # qcom/sm7225-fairphone-fp4 Tested-by: Douglas Anderson Tested-by: Geert Uytterhoeven Tested-by: Jean-Philippe Brucker Tested-by: Dmitry Baryshkov # Qualcomm RB3