From patchwork Wed Mar 29 10:09:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sakari Ailus X-Patchwork-Id: 13192251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31E8C74A5B for ; Wed, 29 Mar 2023 10:10:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231469AbjC2KKB (ORCPT ); Wed, 29 Mar 2023 06:10:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231511AbjC2KJ7 (ORCPT ); Wed, 29 Mar 2023 06:09:59 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 156501BFE; Wed, 29 Mar 2023 03:09:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680084598; x=1711620598; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+Bz+zIFF1opCFSdF/cfscdDB+BU7PpTJxBEssX26HXY=; b=LRGcC0NSB5jP4COKSRMJ1KS2OR09jk8jCHx7AhK2jBUX4XmPMPuq6rOQ jb9Hjkj+Cf3vqWbR+MtWOl5cpwv4AQq1XGX1rAXtvKeoP5tdK+nnBYah1 tfWtr/SiE5m9RlmY5tFvi2jgw90lYcLz8U0yI8cug0gHdyaRe082QrWh6 aCcOhKqFK6/NDFmrf2aEraOEzSavdQsCrV0D9bZFhfICV/g05KF/dnzhB iCCSpBD5awGPrYY9cPVBvJt1Wwe6TZsFbLirNjcCyDco3QVMlZglQPzE2 Ftp3PuVh8w9FbfeA12vSsmfuU0ph4T4y07ouoDFOcf/44dhV3MN6pWBJF Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="343256222" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="343256222" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 03:09:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10663"; a="773517703" X-IronPort-AV: E=Sophos;i="5.98,300,1673942400"; d="scan'208";a="773517703" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2023 03:09:55 -0700 Received: from svinhufvud.ger.corp.intel.com (localhost [IPv6:::1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id 0DBB01224D2; Wed, 29 Mar 2023 13:09:51 +0300 (EEST) From: Sakari Ailus To: linux-acpi@vger.kernel.org Cc: linux-media@vger.kernel.org, rafael@kernel.org, andriy.shevchenko@linux.intel.com, heikki.krogerus@linux.intel.com Subject: [PATCH v8 00/10] ACPI _CRS CSI-2 and MIPI DisCo for Imaging support Date: Wed, 29 Mar 2023 13:09:41 +0300 Message-Id: <20230329100951.1522322-1-sakari.ailus@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hello all, Here's an implementation of ACPI 6.4 _CRS CSI-2 resource descriptor and MIPI DisCo for Imaging 1.0 [1]. What the two basically provide is an officially sanctioned way to describe CSI-2 connected cameras to operating system software, something DT based systems have enjoyed for quite some time already. The implementation digs the information from ACPI tables (_CRS descriptors and data + property extensions) and constructs software nodes that are compatible with Documentation/firmware-guide/acpi/dsd/graph.rst and Documentation/devicetree/bindings/media/video-interface-devices.yaml . No specific driver changes are needed. The first patch of the set also removes the second namespace walk from DSDT root. [1] https://www.mipi.org/specifications/mipi-disco-imaging since v7: - Release _CRS CSI2 resource list directly from acpi_scan_bus(), calling acpi_bus_scan_crs_csi2_release(), instead of acpi_bus_scan_crs_csi2() doing it. - Change first "for" to "because" in comment explaining node allocation. - Move list heads to the beginning of the struct where possible. - Use Andy's rework of the NEXT_PROPERTY() macro. - Unwrap acpi_bus_device_postpone() definition. - Define MIPI_IMG_PORT_PREFIX when the string is needed instead of changing the just added definition. since v6: - Avoid including an extra patch in the set. Otherwise the set is unchanged. since v5: - Add a high level description of the mipi.c file in the heading. - Add a missing memory allocation check (thanks to Dan Carpenter). - Prepend a patch to the set that removes the second ACPI namespace walk due _DEP. Instead, the devices that can't be initialised yet are collected to a linked list that is revisited after initialising the rest of the devices. - Collect information on _CRS CSI2 records during the same, single namespace walk. Effectively since v5, two namespace walks from the namespace root are removed. - The former requires passing state information between functions during the _DSD property initialisation, among other things, introducing additional function arguments in _DSD parsing functions. - The order of the patches has changed somewhat, as the parsing process has changed. Also a patch has been added to collect ACPI devices for which software nodes need to be initialised for DisCo for Imaging. - Elsewhere, acpi_bus_scan() becomes easier to grasp. Comments are also added in acpi_bus_scan() to explain what is being done. - Change the wrong node type warning from acpi_parse_string_ref() to use debug level. since v4: - Add leading dots to comment sentences. - Use UINT_MAX - 1 to denote an unallocated port instead of ~1U. - Unwrap a line. - Get ACPI handle into a local variable in acpi_init_swnodes() for easier use, use acpi_device_handle() to obtain it. - Rework "rotation" property checking and _PLD object access. - Also obtain return value of acpi_get_name() into a local variable before testing it. - Use a local variable for the first element string pointer in acpi_properties_prepare_mipi(). since v3: - Add comments to data structures and functions, code inside functions. - Use ACPI_FAILURE() for testing ACPI framework function return values. - Unwrap a few lines. - Rename list heads as "head", some were called just "list". - Count ACPI handles related to _CRS CSI2 resources during tree walk. - Reshape testing for CSI-2 port allocation in next_csi2_port_index(). - Move allocation of software nodes into a new function, acpi_crs_csi2_alloc_fill_swnodes(). - Comments: acpi_bus_scan_crs_csi2() is to be called on the namespace root. - Use size_t for this_count variable in acpi_bus_scan_crs_csi2(). - Revert the NEXT_PROPERTY() macro condition to original (the suggested one was different). - Remove u union in init_port_csi2_common(). - Fix val array size in init_port_csi2_common(). This issue was masked by the presence of a u32 field in the union. - Use "-" for copyright year range. since v2: - Unwrap a few lines. - Copy CSI-2 resource source string using strscpy() instead of memcpy() in scan_check_crs_csi2_instance. - Fix GRAPH_PORT_NAME() sanity check bug introduced in v2. - Fix snprintf() return value check for port node name in get_mipi_port_handle(). - Fix mipi-img-lane-polarities reading. - Cast bit value to bool instead of using ... ? 1U : 0U. - Get primary fwnode using acpi_fwnode_handle(). - Don't use MIPI_IMG_PREFIX in the array of renamed properties. - Use tabs for indenting drivers/acpi/property.c authors. - Add a comment on assigning ACPI device's secondary fwnode and assign ACPI device's secondary fwnode straight to NULL when unassigning it. since v1: - Update copyright notices. - Include linux/types.h instead of linux/kernel.h in drivers/acpi/mipi.c. - Use SWNODE_GRAPH_PORT_NAME_FMT instead of plain "port@%u" in GRAPH_PORT_NAME macro. - Make the condition in NEXT_PROPERTY() macro easier to read. - Unwrap lines to make them moderately longer than 80 characters. - Use * BITS_PER_TYPE(u8) instead of << 3 to convert bytes to bits in init_port_csi2_common(). - Test ACPI framework call success using ACPI_SUCCESS() instead of comparing with AE_OK. Likewise for ACPI_FAILURE and != AE_OK. - Use newly added SOFTWARE_NODE() macro to construct the root software node. - Use str_has_prefix() to test for a string prefix instead of memcmp(). - Add pr_fmt() macro to drivers/acpi/property.c. - Move logical or operators to the end of the line in acpi_properties_prepare(). - Improve bad node type error in acpi_parse_string_ref(). Sakari Ailus (10): ACPI: scan: Remove the second DSDT traversal ACPI: property: Parse data node string references in properties ACPI: property: Parse _CRS CSI-2 descriptor device property: Add SOFTWARE_NODE() macro for defining software nodes ACPI: property: Prepare generating swnodes for ACPI and DisCo for Imaging ACPI: scan: Generate software nodes based on MIPI DisCo for Imaging ACPI: property: Dig "rotation" property for devices with CSI2 _CRS ACPI: property: Rename parsed MIPI DisCo for Imaging properties ACPI: property: Skip MIPI property table without "mipi-img" prefix ACPI: property: Document _CRS CSI-2 and DisCo for Imaging support drivers/acpi/Makefile | 2 +- drivers/acpi/internal.h | 41 +- drivers/acpi/mipi.c | 796 +++++++++++++++++++++++++++++++++++++++ drivers/acpi/power.c | 2 +- drivers/acpi/property.c | 180 +++++++-- drivers/acpi/scan.c | 227 +++++++++-- include/acpi/acpi_bus.h | 82 ++++ include/linux/property.h | 7 + 8 files changed, 1252 insertions(+), 85 deletions(-) create mode 100644 drivers/acpi/mipi.c