mbox series

[v2,0/4] iio: accel: Share ACPI ROTM parsing between drivers and add it to mxc4005

Message ID 20240422100218.7693-1-hdegoede@redhat.com (mailing list archive)
Headers show
Series iio: accel: Share ACPI ROTM parsing between drivers and add it to mxc4005 | expand

Message

Hans de Goede April 22, 2024, 10:02 a.m. UTC 
Hi All,

Here is v2 of the patch series to refactor the ACPI ROTM orientation matrix
handling in kxcjk-1013 + bmc150-accel to share the code instead of having
2 copies and then also use the shared implementation in the mxc4005 driver
since some MXC6655 ACPI firmware nodes also include this.

Changes in v2:
- Add comment about the Microsoft specification for the "ROTM" ACPI method

Regards,

Hans


Hans de Goede (4):
  iio: accel: kxcjk-1013: Simplify ACPI ROTM mount matrix retreival
  iio: accel: kxcjk-1013: Move ACPI ROTM parsing to new acpi-helpers.h
  iio: bmc150-accel-core: Use acpi_read_mount_matrix() helper
  iio: accel: mxc4005: Read orientation matrix from ACPI ROTM method

 drivers/iio/accel/acpi-helpers.h      | 83 +++++++++++++++++++++++++++
 drivers/iio/accel/bmc150-accel-core.c | 45 +--------------
 drivers/iio/accel/kxcjk-1013.c        | 82 +-------------------------
 drivers/iio/accel/mxc4005.c           | 24 ++++++++
 4 files changed, 113 insertions(+), 121 deletions(-)
 create mode 100644 drivers/iio/accel/acpi-helpers.h

Comments

Rafael J. Wysocki April 22, 2024, 4:06 p.m. UTC | #1 
Hi Hans,

On Mon, Apr 22, 2024 at 12:02 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi All,
>
> Here is v2 of the patch series to refactor the ACPI ROTM orientation matrix
> handling in kxcjk-1013 + bmc150-accel to share the code instead of having
> 2 copies and then also use the shared implementation in the mxc4005 driver
> since some MXC6655 ACPI firmware nodes also include this.
>
> Changes in v2:
> - Add comment about the Microsoft specification for the "ROTM" ACPI method
>
> Regards,
>
> Hans
>
>
> Hans de Goede (4):
>   iio: accel: kxcjk-1013: Simplify ACPI ROTM mount matrix retreival
>   iio: accel: kxcjk-1013: Move ACPI ROTM parsing to new acpi-helpers.h
>   iio: bmc150-accel-core: Use acpi_read_mount_matrix() helper
>   iio: accel: mxc4005: Read orientation matrix from ACPI ROTM method
>
>  drivers/iio/accel/acpi-helpers.h      | 83 +++++++++++++++++++++++++++
>  drivers/iio/accel/bmc150-accel-core.c | 45 +--------------
>  drivers/iio/accel/kxcjk-1013.c        | 82 +-------------------------
>  drivers/iio/accel/mxc4005.c           | 24 ++++++++
>  4 files changed, 113 insertions(+), 121 deletions(-)
>  create mode 100644 drivers/iio/accel/acpi-helpers.h
>
> --

The series LGTM, so please feel free to add

Acked-by: Rafael J. Wysocki <rafael@kernel.org>

to it.

Thanks!