[v3,0/7] ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI)

Message

Ricardo Ribalda Dec. 10, 2024, 7:55 p.m. UTC

We want to be able to compile_test the ipu6 driver in situations with
!ACPI.

In order to do this we had to add some conditional #ifs, which lead to
false positives on the static analysers.

Let's implement some helpers when !ACPI in the acpi headers to make the
code more easier to maintain.

We can land the first patch of this series ASAP to fix the current
smatch warning.

To: Mauro Carvalho Chehab <[e-mail]>
To: Rafael J. Wysocki <[e-mail]>
To: Len Brown <[e-mail]>
To: Robert Moore <[e-mail]>
To: Rafael J. Wysocki <[e-mail]>
Cc: Sakari Ailus <[e-mail]>
Cc: Dan Carpenter <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Signed-off-by: Ricardo Ribalda <[e-mail]>

Changes in v3:
- Prefer static inlines to macros (Thanks Rafael).
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Add helpers in acpi to avoid conditional compilation
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Ricardo Ribalda (7):
      media: ipu-bridge: Fix warning when !ACPI
      ACPI: bus: implement for_each_acpi_dev_match when !ACPI
      ACPI: bus: implement acpi_get_physical_device_location when !ACPI
      ACPI: header: implement acpi_device_handle when !ACPI
      ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI
      ACPI: bus: implement acpi_device_hid when !ACPI
      media: ipu-bridge: Remove unneeded conditional compilations

 drivers/media/pci/intel/ipu-bridge.c | 28 +++++-----------------------
 include/acpi/acpi_bus.h              | 23 ++++++++++++++++++++---
 include/linux/acpi.h                 |  6 ++++++
 3 files changed, 31 insertions(+), 26 deletions(-)
---
base-commit: 6c10d1adae82e1c8da16e7ebd2320e69f20b9d6f
change-id: 20241122-fix-ipu-a2fe28908964

Best regards,

Comments

Mauro Carvalho Chehab Dec. 11, 2024, 8:22 a.m. UTC | #1

Em Tue, 10 Dec 2024 19:55:57 +0000
Ricardo Ribalda <[e-mail]> escreveu:

> We want to be able to compile_test the ipu6 driver in situations with
> !ACPI.
> 
> In order to do this we had to add some conditional #ifs, which lead to
> false positives on the static analysers.
> 
> Let's implement some helpers when !ACPI in the acpi headers to make the
> code more easier to maintain.
> 
> We can land the first patch of this series ASAP to fix the current
> smatch warning.
> 
> To: Mauro Carvalho Chehab <[e-mail]>
> To: Rafael J. Wysocki <[e-mail]>
> To: Len Brown <[e-mail]>
> To: Robert Moore <[e-mail]>
> To: Rafael J. Wysocki <[e-mail]>
> Cc: Sakari Ailus <[e-mail]>
> Cc: Dan Carpenter <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Signed-off-by: Ricardo Ribalda <[e-mail]>
> 
> Changes in v3:
> - Prefer static inlines to macros (Thanks Rafael).
> - Link to v2: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v2:
> - Add helpers in acpi to avoid conditional compilation
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Ricardo Ribalda (7):
>       media: ipu-bridge: Fix warning when !ACPI

Not needed, as patch 7 will revert it.

>       ACPI: bus: implement for_each_acpi_dev_match when !ACPI
>       ACPI: bus: implement acpi_get_physical_device_location when !ACPI
>       ACPI: header: implement acpi_device_handle when !ACPI
>       ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI
>       ACPI: bus: implement acpi_device_hid when !ACPI

patches 2-6 look ok to me, but I'll leave it to ACPI maintainers
to review. From my side:

Acked-by: Mauro Carvalho Chehab <[e-mail]>

>       media: ipu-bridge: Remove unneeded conditional compilations

See my review with my R-B.

As the crucial changes are at ACPI side, I'm assuming that this will
be merged via ACPI tree.

Regards,
Maur

Thanks,
Mauro