From patchwork Wed Feb 25 08:37:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Chary X-Patchwork-Id: 8705 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n1P8l8Ms005738 for ; Wed, 25 Feb 2009 08:47:09 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752089AbZBYIrI (ORCPT ); Wed, 25 Feb 2009 03:47:08 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755532AbZBYIrI (ORCPT ); Wed, 25 Feb 2009 03:47:08 -0500 Received: from iksaif.net ([88.191.73.63]:50461 "EHLO iksaif.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752089AbZBYIrH (ORCPT ); Wed, 25 Feb 2009 03:47:07 -0500 X-Greylist: delayed 599 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Feb 2009 03:47:07 EST Received: from localhost.localdomain (cxr69-11-88-180-139-205.fbx.proxad.net [88.180.139.205]) (Authenticated sender: corentincj@iksaif.net) by iksaif.net (Postfix) with ESMTPA id D61ADC9006B; Wed, 25 Feb 2009 09:40:21 +0100 (CET) From: Corentin Chary To: Andrew Morton Cc: linux-acpi@vger.kernel.org, mjg59@srcf.ucam.org, Corentin Chary Subject: [PATCH] platform/x86: depends instead of select for laptop platform drivers Date: Wed, 25 Feb 2009 09:37:09 +0100 Message-Id: <1235551029-28504-1-git-send-email-corentincj@iksaif.net> X-Mailer: git-send-email 1.6.1.3 In-Reply-To: <20090225000317.82c3c3a7.akpm@linux-foundation.org> References: <20090225000317.82c3c3a7.akpm@linux-foundation.org> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org "I hate `select' and will gleefully leap on any s/select/depends/ patch, whether it works or not :)" Andrew Morton select INPUT is not needed here, because if someone doesn't want INPUT, he won't want these drivers either. Signed-off-by: Corentin Chary --- drivers/platform/x86/Kconfig | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 7a46ed8..8cd903c 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -39,10 +39,10 @@ config ASUS_LAPTOP tristate "Asus Laptop Extras (EXPERIMENTAL)" depends on ACPI depends on EXPERIMENTAL && !ACPI_ASUS + depends on INPUT select LEDS_CLASS select NEW_LEDS select BACKLIGHT_CLASS_DEVICE - select INPUT ---help--- This is the new Linux driver for Asus laptops. It may also support some MEDION, JVC or VICTOR laptops. It makes all the extra buttons generate @@ -185,11 +185,11 @@ config SONYPI_COMPAT config THINKPAD_ACPI tristate "ThinkPad ACPI Laptop Extras" depends on ACPI + depends on INPUT select BACKLIGHT_LCD_SUPPORT select BACKLIGHT_CLASS_DEVICE select HWMON select NVRAM - select INPUT select NEW_LEDS select LEDS_CLASS select NET @@ -307,7 +307,6 @@ config EEEPC_LAPTOP select BACKLIGHT_CLASS_DEVICE select HWMON select RFKILL - select INPUT ---help--- This driver supports the Fn-Fx keys on Eee PC laptops. It also adds the ability to switch camera/wlan on/off.