From patchwork Thu Mar 5 00:44:31 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lin Ming X-Patchwork-Id: 9947 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n250oG0d012921 for ; Thu, 5 Mar 2009 00:50:16 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754624AbZCEAuH (ORCPT ); Wed, 4 Mar 2009 19:50:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754672AbZCEAuH (ORCPT ); Wed, 4 Mar 2009 19:50:07 -0500 Received: from mga14.intel.com ([143.182.124.37]:24881 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754624AbZCEAuF (ORCPT ); Wed, 4 Mar 2009 19:50:05 -0500 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 04 Mar 2009 16:49:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.38,304,1233561600"; d="scan'208";a="116877941" Received: from unknown (HELO [10.239.13.139]) ([10.239.13.139]) by azsmga001.ch.intel.com with ESMTP; 04 Mar 2009 16:49:57 -0800 Subject: Re: linux-next acpi changes make vmware server unusable From: Lin Ming To: Eric Paris Cc: "linux-acpi@vger.kernel.org" , "Moore, Robert" , "Brown, Len" In-Reply-To: <1236203700.3569.11.camel@localhost.localdomain> References: <1236203700.3569.11.camel@localhost.localdomain> Date: Thu, 05 Mar 2009 08:44:31 +0800 Message-Id: <1236213871.28145.1.camel@minggr.sh.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 (2.24.1-2.fc10) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, 2009-03-05 at 05:55 +0800, Eric Paris wrote: > I built a linux-next kernel yesterday and discovered that the free > vmware server 2 would start to boot the kernel and very quickly just > power off. vmware gave some crap message about the MBR being wrong, > which obviously wasn't the case since grub started and the kernel > started booting. Looking at the last line on the serial console for the > new kernel and the next line in a working kernel I knew the next output > was supposed to be in the ACPI code. I bisected drivers/acpi and found > that d6c349993fc7c9dabf873796c4e82bb94544b3ce is first bad commit. Would you please try below patch? ACPICA: Check for non-zero address before being converted to GAS Signed-off-by: Lin Ming --- drivers/acpi/acpica/tbfadt.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) > > I have no idea what vmware is doing, or what we are doing, but before > that patch I was able to boot and after it, vmware just shuts itself > off. > > -Eric > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/acpi/acpica/tbfadt.c b/drivers/acpi/acpica/tbfadt.c index 042d239..af8fbe1 100644 --- a/drivers/acpi/acpica/tbfadt.c +++ b/drivers/acpi/acpica/tbfadt.c @@ -625,12 +625,14 @@ static void acpi_tb_setup_fadt_registers(void) ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT, fadt_pm_info_table[i].source); - acpi_tb_init_generic_address(fadt_pm_info_table[i].target, - source64->space_id, - pm1_register_byte_width, - source64->address + - (fadt_pm_info_table[i]. - register_num * - pm1_register_byte_width)); + if (source64->address) { + acpi_tb_init_generic_address(fadt_pm_info_table[i]. + target, source64->space_id, + pm1_register_byte_width, + source64->address + + (fadt_pm_info_table[i]. + register_num * + pm1_register_byte_width)); + } } }