diff mbox

drivers/acpi/utils.c: Fixed coding style issues

Message ID 1303341624.11397.2.camel@ks-ubuntu (mailing list archive)
State New, archived
Headers show

Commit Message

Karthigan Srinivasan April 20, 2011, 11:20 p.m. UTC 
From e770496964bf749c30df8a19abbdfe0f79d64fb7 Mon Sep 17 00:00:00 2001
From: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
Date: Wed, 20 Apr 2011 18:14:10 -0500
Subject: [PATCH] drivers/acpi/utils.c: Fixed coding style issues.

Fixed brace and comment coding style issues in code.

Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
---
 drivers/acpi/utils.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

Comments

Nicolas Kaiser April 21, 2011, 8:28 a.m. UTC | #1 
* Karthigan Srinivasan <karthigan.srinivasan@hp.com>:
> Fixed brace and comment coding style issues in code.
> 
> Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
> ---
>  drivers/acpi/utils.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
> index b002a47..2cf81a1 100644
> --- a/drivers/acpi/utils.c
> +++ b/drivers/acpi/utils.c
> @@ -99,9 +99,9 @@ acpi_extract_package(union acpi_object *package,
>  
>  		union acpi_object *element = &(package->package.elements[i]);
>  
> -		if (!element) {
> +		if (!element) 
                             ^
You are introducing trailing whitespace.

>  			return AE_BAD_DATA;
> -		}
> +		
   ^^^^^^^^^^^^^
For every pair of braces you clean away, you're adding
two new coding style issues.

Best regards,
Nicolas Kaiser
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index b002a47..2cf81a1 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -99,9 +99,9 @@  acpi_extract_package(union acpi_object *package,
 
 		union acpi_object *element = &(package->package.elements[i]);
 
-		if (!element) {
+		if (!element) 
 			return AE_BAD_DATA;
-		}
+		
 
 		switch (element->type) {
 
@@ -185,9 +185,9 @@  acpi_extract_package(union acpi_object *package,
 		u8 **pointer = NULL;
 		union acpi_object *element = &(package->package.elements[i]);
 
-		if (!element) {
+		if (!element) 
 			return AE_BAD_DATA;
-		}
+		
 
 		switch (element->type) {
 
@@ -303,9 +303,9 @@  acpi_evaluate_reference(acpi_handle handle,
 	u32 i = 0;
 
 
-	if (!list) {
+	if (!list) 
 		return AE_BAD_PARAMETER;
-	}
+	
 
 	/* Evaluate object. */
 
@@ -337,9 +337,9 @@  acpi_evaluate_reference(acpi_handle handle,
 		goto end;
 	}
 
-	if (package->package.count > ACPI_MAX_HANDLES) {
+	if (package->package.count > ACPI_MAX_HANDLES) 
 		return AE_NO_MEMORY;
-	}
+	
 	list->count = package->package.count;
 
 	/* Extract package data. */
@@ -373,7 +373,7 @@  acpi_evaluate_reference(acpi_handle handle,
       end:
 	if (ACPI_FAILURE(status)) {
 		list->count = 0;
-		//kfree(list->handles);
+		/* kfree(list->handles);*/
 	}
 
 	kfree(buffer.pointer);