diff mbox

drivers/acpi/utils.c: Fixed coding style issues

Message ID 1304374605.1619.4.camel@ks-ubuntu (mailing list archive)
State New, archived
Headers show

Commit Message

Karthigan Srinivasan May 2, 2011, 10:16 p.m. UTC 
> On Thu, 2011-04-21 at 11:08 -0500, Karthigan Srinivasan wrote:

Len - I submitted this patch on 4/21 and have not received any
acknowledgement. I am re-submitting it again. Please review and approve.

Best Regards,
Karthigan Srinivasan.

Comments

Joe Perches May 3, 2011, 12:26 a.m. UTC | #1 
On Mon, 2011-05-02 at 17:16 -0500, Karthigan Srinivasan wrote:
>  drivers/acpi/utils.c |   15 ++++++---------
> @@ -373,7 +370,7 @@ acpi_evaluate_reference(acpi_handle handle,
>        end:
>  	if (ACPI_FAILURE(status)) {
>  		list->count = 0;
> -		//kfree(list->handles);
> +		/* kfree(list->handles); */

Just delete the line instead.


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

====

Fixed brace and comment coding style issues is code.

Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
---
 drivers/acpi/utils.c |   15 ++++++---------
 1 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index b002a47..76eaac2 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -99,9 +99,8 @@  acpi_extract_package(union acpi_object *package,
 
 		union acpi_object *element = &(package->package.elements[i]);
 
-		if (!element) {
+		if (!element)
 			return AE_BAD_DATA;
-		}
 
 		switch (element->type) {
 
@@ -185,9 +184,8 @@  acpi_extract_package(union acpi_object *package,
 		u8 **pointer = NULL;
 		union acpi_object *element = &(package->package.elements[i]);
 
-		if (!element) {
+		if (!element)
 			return AE_BAD_DATA;
-		}
 
 		switch (element->type) {
 
@@ -303,9 +301,8 @@  acpi_evaluate_reference(acpi_handle handle,
 	u32 i = 0;
 
 
-	if (!list) {
+	if (!list)
 		return AE_BAD_PARAMETER;
-	}
 
 	/* Evaluate object. */
 
@@ -337,9 +334,9 @@  acpi_evaluate_reference(acpi_handle handle,
 		goto end;
 	}
 
-	if (package->package.count > ACPI_MAX_HANDLES) {
+	if (package->package.count > ACPI_MAX_HANDLES)
 		return AE_NO_MEMORY;
-	}
+
 	list->count = package->package.count;
 
 	/* Extract package data. */
@@ -373,7 +370,7 @@  acpi_evaluate_reference(acpi_handle handle,
       end:
 	if (ACPI_FAILURE(status)) {
 		list->count = 0;
-		//kfree(list->handles);
+		/* kfree(list->handles); */
 	}
 
 	kfree(buffer.pointer);