From patchwork Thu Jun 30 03:34:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "lan,Tianyu" X-Patchwork-Id: 931532 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p5U3XY6i017354 for ; Thu, 30 Jun 2011 03:33:56 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757831Ab1F3Dd4 (ORCPT ); Wed, 29 Jun 2011 23:33:56 -0400 Received: from mga09.intel.com ([134.134.136.24]:37959 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753921Ab1F3Dd4 (ORCPT ); Wed, 29 Jun 2011 23:33:56 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 29 Jun 2011 20:33:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,447,1304319600"; d="scan'208";a="21759537" Received: from lantianyu-ws.sh.intel.com (HELO localhost) ([10.239.35.77]) by orsmga001.jf.intel.com with ESMTP; 29 Jun 2011 20:33:54 -0700 From: Lan Tianyu To: lenb@kernel.org Cc: linux-acpi@vger.kernel.org, tianyu.lan@intel.com, rui.zhang@intel.com Subject: [v2 6/6] ACPI / Battery: Resolve the race condition in the sysfs_remove_battery() Date: Thu, 30 Jun 2011 11:34:12 +0800 Message-Id: <1309404852-15892-1-git-send-email-tianyu.lan@intel.com> X-Mailer: git-send-email 1.7.6.rc2.8.g28eb Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 30 Jun 2011 03:33:57 +0000 (UTC) Use battery->lock in sysfs_remove_battery() to make checking, removing, and clearing bat.dev atomic. This is necessary because sysfs_remove_battery() may be invoked concurrently from different paths. https://bugzilla.kernel.org/show_bug.cgi?id=35642 Signed-off-by: Lan Tianyu --- drivers/acpi/battery.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 4ba339d..40bf01d 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -573,11 +573,16 @@ static int sysfs_add_battery(struct acpi_battery *battery) static void sysfs_remove_battery(struct acpi_battery *battery) { - if (!battery->bat.dev) + mutex_lock(&battery->lock); + if (!battery->bat.dev) { + mutex_unlock(&battery->lock); return; + } + device_remove_file(battery->bat.dev, &alarm_attr); power_supply_unregister(&battery->bat); battery->bat.dev = NULL; + mutex_unlock(&battery->lock); } /*