From patchwork Thu Oct 18 21:12:23 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Youquan Song X-Patchwork-Id: 1608741 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 6BEAE3FE36 for ; Thu, 18 Oct 2012 09:09:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754801Ab2JRJJa (ORCPT ); Thu, 18 Oct 2012 05:09:30 -0400 Received: from mga02.intel.com ([134.134.136.20]:49477 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754788Ab2JRJJ3 (ORCPT ); Thu, 18 Oct 2012 05:09:29 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 18 Oct 2012 02:09:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.80,606,1344236400"; d="scan'208";a="207567140" Received: from linux-youquan.bj.intel.com (HELO localhost.localdomain) ([10.238.155.110]) by orsmga001.jf.intel.com with ESMTP; 18 Oct 2012 02:08:41 -0700 From: Youquan Song To: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, arjan@linux.intel.com, lenb@kernel.org, rjw@sisk.pl Cc: Rik van Riel , Youquan Song , Youquan Song Subject: [PATCH V2 3/4] x86, idle: Set residency to 0 if target Cstate not enter Date: Thu, 18 Oct 2012 17:12:23 -0400 Message-Id: <1350594744-22353-4-git-send-email-youquan.song@intel.com> X-Mailer: git-send-email 1.6.4.2 In-Reply-To: <1350594744-22353-3-git-send-email-youquan.song@intel.com> References: <1350594744-22353-1-git-send-email-youquan.song@intel.com> <1350594744-22353-2-git-send-email-youquan.song@intel.com> <1350594744-22353-3-git-send-email-youquan.song@intel.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org When cpuidle governor choose a C-state to enter for idle CPU, but it notice that there is tasks request to be executed. So the idle CPU will not really enter the target C-state and go to run task. In this situation, it will use the residency of previous really entered target C-states. Obviously, it is not reasonable. So, this patch fix it by set the target C-state residency to 0. Signed-off-by: Youquan Song Signed-off-by: Rik van Riel --- drivers/cpuidle/cpuidle.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index e28f6ea..01dca54 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -144,6 +144,10 @@ int cpuidle_idle_call(void) /* ask the governor for the next state */ next_state = cpuidle_curr_governor->select(drv, dev); if (need_resched()) { + dev->last_residency = 0; + /* give the governor an opportunity to reflect on the outcome */ + if (cpuidle_curr_governor->reflect) + cpuidle_curr_governor->reflect(dev, next_state); local_irq_enable(); return 0; }