From patchwork Fri Oct 19 09:51:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 1617361 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 0C6343FD9C for ; Fri, 19 Oct 2012 09:51:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753915Ab2JSJvl (ORCPT ); Fri, 19 Oct 2012 05:51:41 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:40502 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753054Ab2JSJvk (ORCPT ); Fri, 19 Oct 2012 05:51:40 -0400 Received: by mail-wi0-f172.google.com with SMTP id hq12so35077wib.1 for ; Fri, 19 Oct 2012 02:51:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=8CPgocv9IX2/w2hfkis1Lh5NvzCZs9pUxNXTPZVjD5Y=; b=ZCSSQ2dTKIY5hSELgzxGU7W8Ddb4sfbm1b0Nho1ld+ZXTjvqw+CVYgidbpTcRyKuSP ebJBLveWCNc3dyMdAjZGjCU2uff7KPm/qCv70feqFUILQSwhgylSsfisOk9ZGoTIWqo5 LaW4LE2STUDjY9Hg1qHbYP6jF0jrU+U3opd6uIGU6EUkGzNwZZLlrNiTQBBWs+xcS9Hi Qrv+5ZjnqPWWJkS4K5YkZEWMu5vZ2/1gt2MNKBQO/5uubZ/Gttl5kCBHCmQ7+NXHbAtP gTNIu8UipCB8iNXOconnbgZx58y/KkpspHAiUHTsu41gkgpb5zcG8tjiN4bMt2JF0A/w Sgzg== Received: by 10.180.91.71 with SMTP id cc7mr1967802wib.2.1350640299483; Fri, 19 Oct 2012 02:51:39 -0700 (PDT) Received: from localhost.localdomain (AToulouse-654-1-1-158.w90-5.abo.wanadoo.fr. [90.5.56.158]) by mx.google.com with ESMTPS id dt9sm33952821wib.1.2012.10.19.02.51.36 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Oct 2012 02:51:38 -0700 (PDT) From: Daniel Lezcano To: lenb@kernel.org, rjw@sisk.pl Cc: linux-acpi@vger.kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org Subject: [PATCH 3/5] cpuidle / ACPI : pass the cpuidle_device parameter Date: Fri, 19 Oct 2012 11:51:30 +0200 Message-Id: <1350640292-22468-3-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1350640292-22468-1-git-send-email-daniel.lezcano@linaro.org> References: <1350640292-22468-1-git-send-email-daniel.lezcano@linaro.org> X-Gm-Message-State: ALoCoQmeYJdUSYx3ypCwVVPPU3XwX9CuT86FO58a42dclf8HGzQeNlEfXKOzx5bZTBFr8lc4R94n Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The cpuidle_device is retrieved in the function by using directly the global variable. But the caller of this function already have this device and it can be passed as a parameter. That is one small step to encapsulate the code more. Signed-off-by: Daniel Lezcano --- drivers/acpi/processor_idle.c | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 9aac69b..5c4330f 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -974,13 +974,14 @@ struct cpuidle_driver acpi_idle_driver = { * device i.e. per-cpu data * * @pr: the ACPI processor + * @dev : the cpuidle device */ -static int acpi_processor_setup_cpuidle_cx(struct acpi_processor *pr) +static int acpi_processor_setup_cpuidle_cx(struct acpi_processor *pr, + struct cpuidle_device *dev) { int i, count = CPUIDLE_DRIVER_STATE_START; struct acpi_processor_cx *cx; struct cpuidle_state_usage *state_usage; - struct cpuidle_device *dev = per_cpu(acpi_cpuidle_device, pr->id); if (!pr->flags.power_setup_done) return -EINVAL; @@ -1132,7 +1133,7 @@ int acpi_processor_hotplug(struct acpi_processor *pr) cpuidle_disable_device(dev); acpi_processor_get_power_info(pr); if (pr->flags.power) { - acpi_processor_setup_cpuidle_cx(pr); + acpi_processor_setup_cpuidle_cx(pr, dev); ret = cpuidle_enable_device(dev); } cpuidle_resume_and_unlock(); @@ -1189,8 +1190,8 @@ int acpi_processor_cst_has_changed(struct acpi_processor *pr) continue; acpi_processor_get_power_info(_pr); if (_pr->flags.power) { - acpi_processor_setup_cpuidle_cx(_pr); dev = per_cpu(acpi_cpuidle_device, cpu); + acpi_processor_setup_cpuidle_cx(_pr, dev); cpuidle_enable_device(dev); } } @@ -1259,7 +1260,7 @@ int __cpuinit acpi_processor_power_init(struct acpi_processor *pr) return -ENOMEM; per_cpu(acpi_cpuidle_device, pr->id) = dev; - acpi_processor_setup_cpuidle_cx(pr); + acpi_processor_setup_cpuidle_cx(pr, dev); /* Register per-cpu cpuidle_device. Cpuidle driver * must already be registered before registering device