| Message ID | 1354189996-14431-5-git-send-email-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Hi Bob, This appears to be upstream ACPICA material. Thanks, Rafael On Thursday, November 29, 2012 11:53:15 AM Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > ACPI_ERROR() already appends a newline, so there is no > need for the error messages to include one too. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/acpi/acpica/hwgpe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpica/hwgpe.c b/drivers/acpi/acpica/hwgpe.c > index db40765..610ed72 100644 > --- a/drivers/acpi/acpica/hwgpe.c > +++ b/drivers/acpi/acpica/hwgpe.c > @@ -134,7 +134,7 @@ acpi_hw_low_set_gpe(struct acpi_gpe_event_info *gpe_event_info, u32 action) > break; > > default: > - ACPI_ERROR((AE_INFO, "Invalid GPE Action, %u\n", action)); > + ACPI_ERROR((AE_INFO, "Invalid GPE Action, %u", action)); > return (AE_BAD_PARAMETER); > } > >
Done, thanks. Bob > -----Original Message----- > From: Rafael J. Wysocki [mailto:rjw@sisk.pl] > Sent: Tuesday, January 15, 2013 2:29 PM > To: Moore, Robert > Cc: Colin King; Len Brown; linux-acpi@vger.kernel.org > Subject: Re: [PATCH 4/5] ACPICA: GPE support: remove unnecessary newline > from error messages > > Hi Bob, > > This appears to be upstream ACPICA material. > > Thanks, > Rafael > > > On Thursday, November 29, 2012 11:53:15 AM Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > ACPI_ERROR() already appends a newline, so there is no need for the > > error messages to include one too. > > > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > --- > > drivers/acpi/acpica/hwgpe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/acpica/hwgpe.c b/drivers/acpi/acpica/hwgpe.c > > index db40765..610ed72 100644 > > --- a/drivers/acpi/acpica/hwgpe.c > > +++ b/drivers/acpi/acpica/hwgpe.c > > @@ -134,7 +134,7 @@ acpi_hw_low_set_gpe(struct acpi_gpe_event_info > *gpe_event_info, u32 action) > > break; > > > > default: > > - ACPI_ERROR((AE_INFO, "Invalid GPE Action, %u\n", action)); > > + ACPI_ERROR((AE_INFO, "Invalid GPE Action, %u", action)); > > return (AE_BAD_PARAMETER); > > } > > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center.
diff --git a/drivers/acpi/acpica/hwgpe.c b/drivers/acpi/acpica/hwgpe.c index db40765..610ed72 100644 --- a/drivers/acpi/acpica/hwgpe.c +++ b/drivers/acpi/acpica/hwgpe.c @@ -134,7 +134,7 @@ acpi_hw_low_set_gpe(struct acpi_gpe_event_info *gpe_event_info, u32 action) break; default: - ACPI_ERROR((AE_INFO, "Invalid GPE Action, %u\n", action)); + ACPI_ERROR((AE_INFO, "Invalid GPE Action, %u", action)); return (AE_BAD_PARAMETER); }