| Message ID | 1386209037-31349-1-git-send-email-acelan.kao@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
We had problems with the Intel backlight driver the last time we tried this, so let's push this through their tree for testing first? Cc:ed intel-gfx and Daniel Vetter. On Thu, Dec 05, 2013 at 10:03:57AM +0800, AceLan Kao wrote: > The native/vendor backlight control interface is hardly fail to control the > brightness, and we had encountered many backlight issues result from the broken > ACPI backlight interface, so I think we should promote the native backlight > control interface and use it by default. > > Signed-off-by: AceLan Kao <acelan.kao@canonical.com> > --- > drivers/acpi/video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > index 995e91b..b3032f8 100644 > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -85,7 +85,7 @@ module_param(allow_duplicates, bool, 0644); > * For Windows 8 systems: if set ture and the GPU driver has > * registered a backlight interface, skip registering ACPI video's. > */ > -static bool use_native_backlight = false; > +static bool use_native_backlight = true; > module_param(use_native_backlight, bool, 0644); > > static int register_count; > -- > 1.8.3.2 > >
On Thu, Dec 5, 2013 at 3:32 AM, Matthew Garrett <mjg59@srcf.ucam.org> wrote: > We had problems with the Intel backlight driver the last time we tried > this, so let's push this through their tree for testing first? Cc:ed > intel-gfx and Daniel Vetter. Makes sense imo. Or if I just get a branch with just those patches (it can rebase, I don't really care) I could pull it into our drm-intel-nightly integration tree, which is what everyone is testing anyway. -Daniel > > > On Thu, Dec 05, 2013 at 10:03:57AM +0800, AceLan Kao wrote: >> The native/vendor backlight control interface is hardly fail to control the >> brightness, and we had encountered many backlight issues result from the broken >> ACPI backlight interface, so I think we should promote the native backlight >> control interface and use it by default. >> >> Signed-off-by: AceLan Kao <acelan.kao@canonical.com> >> --- >> drivers/acpi/video.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c >> index 995e91b..b3032f8 100644 >> --- a/drivers/acpi/video.c >> +++ b/drivers/acpi/video.c >> @@ -85,7 +85,7 @@ module_param(allow_duplicates, bool, 0644); >> * For Windows 8 systems: if set ture and the GPU driver has >> * registered a backlight interface, skip registering ACPI video's. >> */ >> -static bool use_native_backlight = false; >> +static bool use_native_backlight = true; >> module_param(use_native_backlight, bool, 0644); >> >> static int register_count; >> -- >> 1.8.3.2 >> >> > -- > Matthew Garrett | mjg59@srcf.ucam.org
On Thu, Dec 05, 2013 at 08:50:21AM +0100, Daniel Vetter wrote: > On Thu, Dec 5, 2013 at 3:32 AM, Matthew Garrett <mjg59@srcf.ucam.org> wrote: > > We had problems with the Intel backlight driver the last time we tried > > this, so let's push this through their tree for testing first? Cc:ed > > intel-gfx and Daniel Vetter. > > Makes sense imo. Or if I just get a branch with just those patches (it > can rebase, I don't really care) I could pull it into our > drm-intel-nightly integration tree, which is what everyone is testing > anyway. Only this patch is needed, all other patches have been in Linus' tree since v3.13-rc1. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 995e91b..b3032f8 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -85,7 +85,7 @@ module_param(allow_duplicates, bool, 0644); * For Windows 8 systems: if set ture and the GPU driver has * registered a backlight interface, skip registering ACPI video's. */ -static bool use_native_backlight = false; +static bool use_native_backlight = true; module_param(use_native_backlight, bool, 0644); static int register_count;
The native/vendor backlight control interface is hardly fail to control the brightness, and we had encountered many backlight issues result from the broken ACPI backlight interface, so I think we should promote the native backlight control interface and use it by default. Signed-off-by: AceLan Kao <acelan.kao@canonical.com> --- drivers/acpi/video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)