| Message ID | 1396886819-2637-10-git-send-email-rui.zhang@intel.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Tuesday, April 08, 2014 12:06:56 AM Zhang Rui wrote: > For ACPI PIC (PNP0000) and Timer (PNP0100) device objects, although > they have _HID control method, but they should not be enumerated to > platform bus, because there will never be any platform drivers for them. > > Thus an exclude id list is introduced in this patch to prevent > those platform device nodes from being created. > > Signed-off-by: Zhang Rui <rui.zhang@intel.com> This should go into [6/12] as well. > --- > drivers/acpi/acpi_platform.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > index 33376a9..91ed43a 100644 > --- a/drivers/acpi/acpi_platform.c > +++ b/drivers/acpi/acpi_platform.c > @@ -22,6 +22,17 @@ > > ACPI_MODULE_NAME("platform"); > > +static const struct acpi_device_id excluded_id_list[] = { > + {"PNP0000", 0}, /* PIC */ > + {"PNP0100", 0}, /* Timer */ > + {"", 0}, > +}; > + > +static bool is_exclusive_device(struct acpi_device *dev) > +{ > + return !acpi_match_device_ids(dev, excluded_id_list); > +} > + > /** > * acpi_create_platform_device - Create platform device for ACPI device node > * @adev: ACPI device node to create a platform device for. > @@ -48,6 +59,9 @@ int acpi_create_platform_device(struct acpi_device *adev, > if (adev->physical_node_count) > return 0; > > + if (is_exclusive_device(adev)) > + return 0; > + > INIT_LIST_HEAD(&resource_list); > count = acpi_dev_get_resources(adev, &resource_list, NULL, NULL); > if (count < 0) { >
On Mon, 2014-04-28 at 00:21 +0200, Rafael J. Wysocki wrote: > On Tuesday, April 08, 2014 12:06:56 AM Zhang Rui wrote: > > For ACPI PIC (PNP0000) and Timer (PNP0100) device objects, although > > they have _HID control method, but they should not be enumerated to > > platform bus, because there will never be any platform drivers for them. > > > > Thus an exclude id list is introduced in this patch to prevent > > those platform device nodes from being created. > > > > Signed-off-by: Zhang Rui <rui.zhang@intel.com> > > This should go into [6/12] as well. > I think it is okay to keep them as separate patches because they do not break bisect. And this patch is just a cleanup, it does not fix a real BUG in patch 6/12. thanks, rui > > --- > > drivers/acpi/acpi_platform.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > > index 33376a9..91ed43a 100644 > > --- a/drivers/acpi/acpi_platform.c > > +++ b/drivers/acpi/acpi_platform.c > > @@ -22,6 +22,17 @@ > > > > ACPI_MODULE_NAME("platform"); > > > > +static const struct acpi_device_id excluded_id_list[] = { > > + {"PNP0000", 0}, /* PIC */ > > + {"PNP0100", 0}, /* Timer */ > > + {"", 0}, > > +}; > > + > > +static bool is_exclusive_device(struct acpi_device *dev) > > +{ > > + return !acpi_match_device_ids(dev, excluded_id_list); > > +} > > + > > /** > > * acpi_create_platform_device - Create platform device for ACPI device node > > * @adev: ACPI device node to create a platform device for. > > @@ -48,6 +59,9 @@ int acpi_create_platform_device(struct acpi_device *adev, > > if (adev->physical_node_count) > > return 0; > > > > + if (is_exclusive_device(adev)) > > + return 0; > > + > > INIT_LIST_HEAD(&resource_list); > > count = acpi_dev_get_resources(adev, &resource_list, NULL, NULL); > > if (count < 0) { > > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 4/28/2014 3:57 AM, Zhang Rui wrote: > On Mon, 2014-04-28 at 00:21 +0200, Rafael J. Wysocki wrote: >> On Tuesday, April 08, 2014 12:06:56 AM Zhang Rui wrote: >>> For ACPI PIC (PNP0000) and Timer (PNP0100) device objects, although >>> they have _HID control method, but they should not be enumerated to >>> platform bus, because there will never be any platform drivers for them. >>> >>> Thus an exclude id list is introduced in this patch to prevent >>> those platform device nodes from being created. >>> >>> Signed-off-by: Zhang Rui <rui.zhang@intel.com> >> This should go into [6/12] as well. >> > I think it is okay to keep them as separate patches because they do not > break bisect. And this patch is just a cleanup, it does not fix a real > BUG in patch 6/12. OK -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c index 33376a9..91ed43a 100644 --- a/drivers/acpi/acpi_platform.c +++ b/drivers/acpi/acpi_platform.c @@ -22,6 +22,17 @@ ACPI_MODULE_NAME("platform"); +static const struct acpi_device_id excluded_id_list[] = { + {"PNP0000", 0}, /* PIC */ + {"PNP0100", 0}, /* Timer */ + {"", 0}, +}; + +static bool is_exclusive_device(struct acpi_device *dev) +{ + return !acpi_match_device_ids(dev, excluded_id_list); +} + /** * acpi_create_platform_device - Create platform device for ACPI device node * @adev: ACPI device node to create a platform device for. @@ -48,6 +59,9 @@ int acpi_create_platform_device(struct acpi_device *adev, if (adev->physical_node_count) return 0; + if (is_exclusive_device(adev)) + return 0; + INIT_LIST_HEAD(&resource_list); count = acpi_dev_get_resources(adev, &resource_list, NULL, NULL); if (count < 0) {
For ACPI PIC (PNP0000) and Timer (PNP0100) device objects, although they have _HID control method, but they should not be enumerated to platform bus, because there will never be any platform drivers for them. Thus an exclude id list is introduced in this patch to prevent those platform device nodes from being created. Signed-off-by: Zhang Rui <rui.zhang@intel.com> --- drivers/acpi/acpi_platform.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)