diff mbox

[1/2] APEI, GHES: Cleanup unnecessary function for lock-less list

Message ID 1406530260-26078-2-git-send-email-gong.chen@linux.intel.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Chen Gong July 28, 2014, 6:50 a.m. UTC
We have provided a reverse function for lock-less list so delete
uncessary codes.

Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
Acked-by: Borislav Petkov <bp@suse.de>
---
 drivers/acpi/apei/ghes.c | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

Comments

Naoya Horiguchi July 28, 2014, 2:48 p.m. UTC | #1
On Mon, Jul 28, 2014 at 02:50:59AM -0400, Chen, Gong wrote:
> We have provided a reverse function for lock-less list so delete
> uncessary codes.
> 
> Signed-off-by: Chen, Gong <gong.chen@linux.intel.com>
> Acked-by: Borislav Petkov <bp@suse.de>

Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
>  drivers/acpi/apei/ghes.c | 18 ++----------------
>  1 file changed, 2 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index dab7cb7..1f9fba9 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -734,20 +734,6 @@ static int ghes_notify_sci(struct notifier_block *this,
>  	return ret;
>  }
>  
> -static struct llist_node *llist_nodes_reverse(struct llist_node *llnode)
> -{
> -	struct llist_node *next, *tail = NULL;
> -
> -	while (llnode) {
> -		next = llnode->next;
> -		llnode->next = tail;
> -		tail = llnode;
> -		llnode = next;
> -	}
> -
> -	return tail;
> -}
> -
>  static void ghes_proc_in_irq(struct irq_work *irq_work)
>  {
>  	struct llist_node *llnode, *next;
> @@ -761,7 +747,7 @@ static void ghes_proc_in_irq(struct irq_work *irq_work)
>  	 * Because the time order of estatus in list is reversed,
>  	 * revert it back to proper order.
>  	 */
> -	llnode = llist_nodes_reverse(llnode);
> +	llnode = llist_reverse_order(llnode);
>  	while (llnode) {
>  		next = llnode->next;
>  		estatus_node = llist_entry(llnode, struct ghes_estatus_node,
> @@ -794,7 +780,7 @@ static void ghes_print_queued_estatus(void)
>  	 * Because the time order of estatus in list is reversed,
>  	 * revert it back to proper order.
>  	 */
> -	llnode = llist_nodes_reverse(llnode);
> +	llnode = llist_reverse_order(llnode);
>  	while (llnode) {
>  		estatus_node = llist_entry(llnode, struct ghes_estatus_node,
>  					   llnode);
> -- 
> 2.0.0.rc2
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
index dab7cb7..1f9fba9 100644
--- a/drivers/acpi/apei/ghes.c
+++ b/drivers/acpi/apei/ghes.c
@@ -734,20 +734,6 @@  static int ghes_notify_sci(struct notifier_block *this,
 	return ret;
 }
 
-static struct llist_node *llist_nodes_reverse(struct llist_node *llnode)
-{
-	struct llist_node *next, *tail = NULL;
-
-	while (llnode) {
-		next = llnode->next;
-		llnode->next = tail;
-		tail = llnode;
-		llnode = next;
-	}
-
-	return tail;
-}
-
 static void ghes_proc_in_irq(struct irq_work *irq_work)
 {
 	struct llist_node *llnode, *next;
@@ -761,7 +747,7 @@  static void ghes_proc_in_irq(struct irq_work *irq_work)
 	 * Because the time order of estatus in list is reversed,
 	 * revert it back to proper order.
 	 */
-	llnode = llist_nodes_reverse(llnode);
+	llnode = llist_reverse_order(llnode);
 	while (llnode) {
 		next = llnode->next;
 		estatus_node = llist_entry(llnode, struct ghes_estatus_node,
@@ -794,7 +780,7 @@  static void ghes_print_queued_estatus(void)
 	 * Because the time order of estatus in list is reversed,
 	 * revert it back to proper order.
 	 */
-	llnode = llist_nodes_reverse(llnode);
+	llnode = llist_reverse_order(llnode);
 	while (llnode) {
 		estatus_node = llist_entry(llnode, struct ghes_estatus_node,
 					   llnode);