From patchwork Thu Jan 21 00:17:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Loc Ho X-Patchwork-Id: 8075631 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0E6089F1C0 for ; Thu, 21 Jan 2016 00:17:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3745E205E8 for ; Thu, 21 Jan 2016 00:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 657CE205E3 for ; Thu, 21 Jan 2016 00:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbcAUARw (ORCPT ); Wed, 20 Jan 2016 19:17:52 -0500 Received: from mail-pf0-f174.google.com ([209.85.192.174]:36273 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbcAUARu (ORCPT ); Wed, 20 Jan 2016 19:17:50 -0500 Received: by mail-pf0-f174.google.com with SMTP id n128so12942156pfn.3 for ; Wed, 20 Jan 2016 16:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=apm.com; s=apm; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LmP7DNERZcBpUk29DO/LVNMiUV4R6lwadHL+2boDlRg=; b=NsqASfgZVTX1a7VjyFwTVKNdhJlqJMQd9G5cIRhZYUorajVO+U1UvqNwrGb534tc0q /hVMmdcH/6kApobot7Rrjtgh5M72UEiYEgyvpJOn47tN9TnsKCwp8V1RFF5vAea0MtrT 7yL4yi6rws9jyTEhz7xn8P5ByZWVma6w4eD98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LmP7DNERZcBpUk29DO/LVNMiUV4R6lwadHL+2boDlRg=; b=Imcn6MJ2b1IVLTL0VhNIGek64pxwytK5WVXaKI3S6QwIREw0BMdKyOWuLCksrfWxId jDeUliHkgp44wZoy/f5lNuQIUFDptXmBLKIm9cymrBQobMk/h8uZdDkC8sfIy30JqHXF 84Vt5sMAZXY7R1lU1jUDzPwi4N13ppjFtl6nL9Cuad7DtUzNQYPhUqtMVe+W1Pn1kUBI xFf5cvq6HfkXDO1DsGNkWLLc91M7wtYucZJa5Y+7GI2729+0NYa22B5O7qRH5gQ51+As WYHFs1tNBlge6uo4DMRMwFvzkddvhjOy2CmLxCtCbI6kHeNpZ02DM2+Wpw5ayMBUTd3z GC8Q== X-Gm-Message-State: ALoCoQnH7rgZfOaX9jO7sxLksgbSH9gTvOnxk5arsOOi2hdJLtDg5I8NbKZ/TtErRgEjhQFJGSI5XivIPsRkUGfXV2nGE/U+1g== X-Received: by 10.98.72.132 with SMTP id q4mr55995425pfi.53.1453335470101; Wed, 20 Jan 2016 16:17:50 -0800 (PST) Received: from localhost.localdomain ([198.137.200.11]) by smtp.gmail.com with ESMTPSA id ry1sm51593092pab.30.2016.01.20.16.17.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jan 2016 16:17:48 -0800 (PST) From: Loc Ho To: bp@alien8.de, dougthompson@xmission.com, mchehab@osg.samsung.com, tomasz.nowicki@linaro.org, fu.wei@linaro.org, rjw@rjwysocki.net, lenb@kernel.org Cc: linux-edac@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, patches@apm.com, Loc Ho , Tuan Phan Subject: [PATCH v4 1/2] acpi: Fix proper return code for function acpi_gsi_to_irq Date: Wed, 20 Jan 2016 17:17:38 -0700 Message-Id: <1453335459-3617-2-git-send-email-lho@apm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1453335459-3617-1-git-send-email-lho@apm.com> References: <1453335459-3617-1-git-send-email-lho@apm.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The function acpi_gsi_to_irq must return 0 on success as the caller ghes_probe expects an 0 for success. This change also matches x86 implementation. Signed-off-by: Tuan Phan Signed-off-by: Loc Ho --- drivers/acpi/gsi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/gsi.c b/drivers/acpi/gsi.c index ee9e0f2..7b109bd 100644 --- a/drivers/acpi/gsi.c +++ b/drivers/acpi/gsi.c @@ -24,7 +24,7 @@ static struct fwnode_handle *acpi_gsi_domain_id; * * irq location updated with irq value [>0 on success, 0 on failure] * - * Returns: linux IRQ number on success (>0) + * Returns: 0 on success * -EINVAL on failure */ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) @@ -37,7 +37,7 @@ int acpi_gsi_to_irq(u32 gsi, unsigned int *irq) * *irq == 0 means no mapping, that should * be reported as a failure */ - return (*irq > 0) ? *irq : -EINVAL; + return (*irq > 0) ? 0 : -EINVAL; } EXPORT_SYMBOL_GPL(acpi_gsi_to_irq);