From patchwork Fri Jul 28 22:25:03 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baicar X-Patchwork-Id: 9869565 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1AA3E6038F for ; Fri, 28 Jul 2017 22:25:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FAC828924 for ; Fri, 28 Jul 2017 22:25:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0150228917; Fri, 28 Jul 2017 22:25:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83C5528917 for ; Fri, 28 Jul 2017 22:25:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752730AbdG1WZI (ORCPT ); Fri, 28 Jul 2017 18:25:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38818 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752725AbdG1WZH (ORCPT ); Fri, 28 Jul 2017 18:25:07 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 664B460A82; Fri, 28 Jul 2017 22:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501280707; bh=y1vJzMrZ4BU7Gj8LkEM4g1BuPRyexVMzbL9vQyHD87k=; h=From:To:Cc:Subject:Date:From; b=jmcSgCb92TvQgIOHcf0dLt+7jBXAzbLvlM3pgN+MWiY2jSLxp7W3ieRvOT+h8q0qj sBxXo77Rku3K10APGblvsuU/kz2193Q7Fmxvtdg5jmbesRgrd3+bVHwuvK+RTz2dH/ H8xQv2p+wAt5eCN/I7Oa6PeL1G2xTexiaOfKkfTg= Received: from tbaicar-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tbaicar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D8FD8607C4; Fri, 28 Jul 2017 22:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1501280706; bh=y1vJzMrZ4BU7Gj8LkEM4g1BuPRyexVMzbL9vQyHD87k=; h=From:To:Cc:Subject:Date:From; b=LGjwe+TzVIAXU3lafM4Pkbtl6xj8+ajwjkBDNeODSMUzzdtUTCjmJih6ssA1NVnQb /eJEHKNWrZXA/8z4xN5+dPNMj9utR1ScUPIusBSINbZYN/gS/9qcjZXqSF1J79gaPz 7JByh2xEoctBY4SOiyu3p8NfFoQPJ6YWOl6MGJfE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D8FD8607C4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org From: Tyler Baicar To: rjw@rjwysocki.net, lenb@kernel.org, will.deacon@arm.com, james.morse@arm.com, bp@suse.de, shiju.jose@huawei.com, geliangtang@gmail.com, andriy.shevchenko@linux.intel.com, tony.luck@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tyler Baicar Subject: [PATCH] acpi: apei: clear error status before acknowledging the error Date: Fri, 28 Jul 2017 16:25:03 -0600 Message-Id: <1501280703-21471-1-git-send-email-tbaicar@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently we acknowledge errors before clearing the error status. This could cause a new error to be populated by firmware in-between the error acknowledgment and the error status clearing which would cause the second error's status to be cleared without being handled. So, clear the error status before acknowledging the errors. Also, make sure to acknowledge the error if the error status read fails. Signed-off-by: Tyler Baicar --- drivers/acpi/apei/ghes.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index d661d45..6a6895a 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -743,17 +743,15 @@ static int ghes_proc(struct ghes *ghes) } ghes_do_proc(ghes, ghes->estatus); +out: + ghes_clear_estatus(ghes); /* * GHESv2 type HEST entries introduce support for error acknowledgment, * so only acknowledge the error if this support is present. */ if (is_hest_type_generic_v2(ghes)) { rc = ghes_ack_error(ghes->generic_v2); - if (rc) - return rc; } -out: - ghes_clear_estatus(ghes); return rc; }