From patchwork Mon Aug 28 17:11:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baicar X-Patchwork-Id: 9925879 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5C71260311 for ; Mon, 28 Aug 2017 17:12:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 40A2C28764 for ; Mon, 28 Aug 2017 17:12:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3570D28766; Mon, 28 Aug 2017 17:12:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B371228764 for ; Mon, 28 Aug 2017 17:12:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751231AbdH1RMA (ORCPT ); Mon, 28 Aug 2017 13:12:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50798 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbdH1RMA (ORCPT ); Mon, 28 Aug 2017 13:12:00 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B667B60729; Mon, 28 Aug 2017 17:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503940319; bh=G3kwWNboDQMvLVPzX1enPGCPnrcj0LNW6rEW3/Gc3I4=; h=From:To:Cc:Subject:Date:From; b=V8wVYKZggh0elmu0+Ro0acj2LkPnussVvugpgd7rQ7n44VJ+ZaWu8POpaTO66HRWZ M6o6oGXYveuty0AP0FZCqTAvYBMJ272IHdlANuin9CKZx8YOOevPngQfAtZW8pC/M9 sCn9GgjXrlf18xvACYELvzZFzvlQfevOqVH8jl4w= Received: from tbaicar-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tbaicar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 73F5E60725; Mon, 28 Aug 2017 17:11:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1503940318; bh=G3kwWNboDQMvLVPzX1enPGCPnrcj0LNW6rEW3/Gc3I4=; h=From:To:Cc:Subject:Date:From; b=BI/WUkr3p74k4d3L18iz73hRBeonoNMKDOrySckwPT4EzWTB276EyIrnndHLWhkkG GmhjVIR9tOPNy7L+1lC6vmI9A3rHpwf+GZLlBoLER6CUQSLWl+AD52ok0/DJXHBuHJ VOwtnhhDfxAtW7jkG6fHFwtlm4dntBuq4fuyTRxg= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 73F5E60725 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org From: Tyler Baicar To: rjw@rjwysocki.net, lenb@kernel.org, will.deacon@arm.com, james.morse@arm.com, bp@suse.de, prarit@redhat.com, punit.agrawal@arm.com, shiju.jose@huawei.com, andriy.shevchenko@linux.intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Tyler Baicar Subject: [PATCH] acpi: apei: call into AER handling regardless of severity Date: Mon, 28 Aug 2017 11:11:54 -0600 Message-Id: <1503940314-29526-1-git-send-email-tbaicar@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Currently the GHES code only calls into the AER driver for recoverable type errors. This is incorrect because errors of other severities do not get logged by the AER driver and do not get exposed to user space via the AER trace event. So, call into the AER driver for PCIe errors regardless of the severity. Signed-off-by: Tyler Baicar --- drivers/acpi/apei/ghes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index d661d45..5cab238 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -489,9 +489,7 @@ static void ghes_do_proc(struct ghes *ghes, else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { struct cper_sec_pcie *pcie_err = acpi_hest_get_payload(gdata); - if (sev == GHES_SEV_RECOVERABLE && - sec_sev == GHES_SEV_RECOVERABLE && - pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID && + if (pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID && pcie_err->validation_bits & CPER_PCIE_VALID_AER_INFO) { unsigned int devfn; int aer_severity;