| Message ID | 1662026651-172787-1-git-send-email-john.garry@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | ACPI: platform: Use PLATFORM_DEVID_NONE in acpi_create_platform_device() | expand |
On Thu, Sep 1, 2022 at 1:10 PM John Garry <john.garry@huawei.com> wrote: > > Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE. Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Signed-off-by: John Garry <john.garry@huawei.com> > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > index de3cbf152dee..d33334c9b8e5 100644 > --- a/drivers/acpi/acpi_platform.c > +++ b/drivers/acpi/acpi_platform.c > @@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev, > pdevinfo.parent = adev->parent ? > acpi_get_first_physical_node(adev->parent) : NULL; > pdevinfo.name = dev_name(&adev->dev); > - pdevinfo.id = -1; > + pdevinfo.id = PLATFORM_DEVID_NONE; > pdevinfo.res = resources; > pdevinfo.num_res = count; > pdevinfo.fwnode = acpi_fwnode_handle(adev); > -- > 2.35.3 >
On Thu, Sep 1, 2022 at 12:25 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Thu, Sep 1, 2022 at 1:10 PM John Garry <john.garry@huawei.com> wrote: > > > > Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE. > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > > Signed-off-by: John Garry <john.garry@huawei.com> > > > > diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c > > index de3cbf152dee..d33334c9b8e5 100644 > > --- a/drivers/acpi/acpi_platform.c > > +++ b/drivers/acpi/acpi_platform.c > > @@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev, > > pdevinfo.parent = adev->parent ? > > acpi_get_first_physical_node(adev->parent) : NULL; > > pdevinfo.name = dev_name(&adev->dev); > > - pdevinfo.id = -1; > > + pdevinfo.id = PLATFORM_DEVID_NONE; > > pdevinfo.res = resources; > > pdevinfo.num_res = count; > > pdevinfo.fwnode = acpi_fwnode_handle(adev); > > -- Applied as 6.1 material, thanks!
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c index de3cbf152dee..d33334c9b8e5 100644 --- a/drivers/acpi/acpi_platform.c +++ b/drivers/acpi/acpi_platform.c @@ -140,7 +140,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev, pdevinfo.parent = adev->parent ? acpi_get_first_physical_node(adev->parent) : NULL; pdevinfo.name = dev_name(&adev->dev); - pdevinfo.id = -1; + pdevinfo.id = PLATFORM_DEVID_NONE; pdevinfo.res = resources; pdevinfo.num_res = count; pdevinfo.fwnode = acpi_fwnode_handle(adev);
Instead of hardcoding the value for the id, use PLATFORM_DEVID_NONE. Signed-off-by: John Garry <john.garry@huawei.com>